Skip to content

fix: server params refactor broke format #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025
Merged

fix: server params refactor broke format #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c789c9
fix: server params refactor broke format
SamMousa Apr 1, 2025
7779f7e
chore: fix phsptan config to allow bare array typehint
SamMousa Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ parameters:
checkMaybeUndefinedVariables: true
treatPhpDocTypesAsCertain: false
ignoreErrors:
- identifier: missingType.iterableValue
path: tests/_support/_generated/FunctionalTesterActions.php
- identifier: return.type
path: tests/_support/_generated/FunctionalTesterActions.php
message: "# but returns mixed.$#"
Expand Down
2 changes: 1 addition & 1 deletion src/Codeception/Module/Yii2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ public function _initialize(): void
$this->server = $_SERVER;
// Adds the required server params. Note this is done separately from the request cycle since someone might call
// `Url::to` before doing a request, which would instantiate the request component with incorrect server params.
$_SERVER = [...$_SERVER, $this->getServerParams()];
$_SERVER = [...$_SERVER, ...$this->getServerParams()];
}

/**
Expand Down