Skip to content

fix: check using isset instead of !== null for possibly non-existent … #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

fix: check using isset instead of !== null for possibly non-existent … #127

merged 1 commit into from
Feb 27, 2025
+11 −5

Conversation

SamMousa
Copy link
Collaborator

…property

@SamMousa SamMousa requested a review from TavoNiievez February 26, 2025 16:02
@SamMousa
Copy link
Collaborator Author

@TavoNiievez pinging you so you can merge and do your first automated release! :-D

@SamMousa
Copy link
Collaborator Author

Click merge!

Arhell
Arhell approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samdark check please

@Arhell Arhell requested a review from samdark February 27, 2025 00:04
@SamMousa SamMousa merged commit 0be6829 into master Feb 27, 2025
2 checks passed
@SamMousa SamMousa deleted the fix-internal-domains branch February 27, 2025 08:24
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell

@TavoNiievez TavoNiievez

@samdark samdark

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SamMousa @Arhell @TavoNiievez