Skip to content

Make url parameter optional in seePageIsAvailable #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TavoNiievez merged 1 commit into from
Feb 7, 2021
Merged

Make url parameter optional in seePageIsAvailable #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/Codeception/Module/Symfony/BrowserAssertionsTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,20 +34,26 @@ public function rebootClientKernel(): void
}

/**
* Goes to a page and check that it can be accessed.
* Verifies that a page is available.
* By default it checks the current page, specify the `$url` parameter to change it.
*
* ```php
* <?php
* $I->seePageIsAvailable('/dashboard');
* $I->amOnPage('/dashboard');
* $I->seePageIsAvailable();
*
* $I->seePageIsAvailable('/dashboard'); // Same as above
* ```
*
* @param string $url
* @param string|null $url
*/
public function seePageIsAvailable(string $url): void
public function seePageIsAvailable(string $url = null): void
{
$this->amOnPage($url);
if ($url !== null) {
$this->amOnPage($url);
$this->seeInCurrentUrl($url);
}
$this->seeResponseCodeIsSuccessful();
$this->seeInCurrentUrl($url);
}

/**
Expand Down