Skip to content

Remove Symfony 3.4 Support #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TavoNiievez merged 1 commit into from
Jan 26, 2021
Merged

Remove Symfony 3.4 Support #105

TavoNiievez merged 1 commit into from
Jan 26, 2021

Conversation

@TavoNiievez
Copy link
Member

@TavoNiievez TavoNiievez commented Jan 24, 2021 •
edited
Loading

With this PR:

  • The new minimum supported version is Symfony 4.4.
  • All logic and docs that reference Symfony 3.4 are removed.
  • Now _getContainer returns the test container first if it exists.
  • getPossibleKernelClasses and initializeSymfonyCache methods removed.
  • Removed the var_path config parameter.

@TavoNiievez TavoNiievez added this to the 2.0.0 milestone Jan 24, 2021
@TavoNiievez TavoNiievez marked this pull request as ready for review January 25, 2021 00:28
@TavoNiievez TavoNiievez merged commit 70abb83 into Codeception:master Jan 26, 2021
@TavoNiievez TavoNiievez deleted the remove_sf3.4 branch January 26, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Naktibalda Naktibalda Naktibalda approved these changes

@DavertMik DavertMik Awaiting requested review from DavertMik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@TavoNiievez @Naktibalda