2.0:feat(multi-application): allow absolute path in dump files #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is highly useful in multi-application setups where dump files may not be inside the project directory but in a shared fixture directory. The current alternative is to symlink each file into the project dir.
calvinalkan
changed the title
calvinalkan
changed the title
Naktibalda
requested changes
Aug 19, 2022
| @@ -532,18 +532,24 @@ private function readSql($databaseKey = null, $databaseConfig = null): void | |||
| * @return bool|null|string|string[] | |||
| * @throws ModuleConfigException | |||
| */ | |||
| private function readSqlFile(string $filePath): ?string | |||
| private function readSqlFile(string $configPath): ?string | |||
There was a problem hiding this comment.
was it necessary to rename parameter?
| if(file_exists($configPath)) { | ||
| $dumpFile = $configPath; | ||
| }elseif (file_exists(Configuration::projectDir().$configPath)){ | ||
| $dumpFile = Configuration::projectDir().$configPath; |
There was a problem hiding this comment.
Please check Configuration::projectDir() . $configPath first for better backwards compatibility.
| $dumpFile = $configPath; | ||
| }elseif (file_exists(Configuration::projectDir().$configPath)){ | ||
| $dumpFile = Configuration::projectDir().$configPath; | ||
| }else { |
There was a problem hiding this comment.
Formatting. Please put space after if and before elseif and else keywords.
Please put spaces on both sides of concatenation operator.
| ); | ||
| } | ||
|
|
||
| $sql = file_get_contents(Configuration::projectDir() . $filePath); | ||
|
|
There was a problem hiding this comment.
And delete spaces in empty line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is highly useful in multi-application setups
where dump files may not be inside the project
directory but in a shared fixture directory.
The current alternative is to symlink each file into the project dir.