Skip to content

added md as default for column size #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
LinKCoding wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −3
Draft

added md as default for column size #3386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74a9f4a
added md as default for column size
LinKCoding Jun 25, 2026
b3e51ab
moved default column size to its own file to avoid export from public…
LinKCoding Jun 26, 2026
d8b35bc
added constants file
LinKCoding Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/gamut/src/DataList/Tables/Rows/TableHeaderRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { memo, ReactElement } from 'react';
import { FlexBox } from '../../..';
import { ListCol } from '../../../List';
import { useListContext } from '../../../List/ListProvider';
import { DEFAULT_COLUMN_SIZE } from '../../constants';
import {
ExpandControl,
FilterControl,
Expand Down Expand Up @@ -56,7 +57,7 @@ export const TableHeaderRow: HeaderComponent = ({
)}
</ListCol>
)}
{columns.map(({ key, header, sortable, filters, ...colProps }) => {
{columns.map(({ key, header, sortable, filters, size, ...colProps }) => {
const rowProperty = key as string;
const renderKey = prefixId(`header-col-${rowProperty}`);
const columnText = String(header || key);
Expand All @@ -73,6 +74,7 @@ export const TableHeaderRow: HeaderComponent = ({
{...colProps}
aria-sort={sortable ? ariaSortDirection : undefined}
columnHeader
size={size ?? DEFAULT_COLUMN_SIZE}
>
<FlexBox
alignItems={selectable ? 'center' : 'flex-end'}
Expand Down
3 changes: 2 additions & 1 deletion packages/gamut/src/DataList/Tables/Rows/TableRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { ListCol, ListRow } from '../../../List';
import { ColProps } from '../../../List/elements';
import { useListContext } from '../../../List/ListProvider';
import { Shimmer } from '../../../Loading/Shimmer';
import { DEFAULT_COLUMN_SIZE } from '../../constants';
import { ExpandControl, SelectControl } from '../../Controls';
import { useControlContext } from '../../hooks/useListControls';
import { ColumnConfig, IdentifiableKeys } from '../../types';
Expand Down Expand Up @@ -108,7 +109,7 @@ export const TableRow: DataRow = ({
const newKey = prefixId(`${id}-col-${String(key)}`);
const colProps = {
...listColProps,
size,
size: size ?? DEFAULT_COLUMN_SIZE,
justify,
fill,
type,
Expand Down
3 changes: 3 additions & 0 deletions packages/gamut/src/DataList/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { DataGridColumnSize } from './types';

export const DEFAULT_COLUMN_SIZE: DataGridColumnSize = 'md';
4 changes: 3 additions & 1 deletion packages/gamut/src/DataList/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ export type IdentifiableKeys<T> = Extract<

export type FilterOption = string | { text: string; value: string };

export type DataGridColumnSize = Exclude<ListColProps['size'], 'content'>;

export interface ColumnConfig<T> {
key: keyof T;
/**
Expand All @@ -73,7 +75,7 @@ export interface ColumnConfig<T> {
*/
header?: string;
type?: ListColProps['type'];
size?: Exclude<ListColProps['size'], 'content'>;
size?: DataGridColumnSize;
render?: (row: T) => ReactElement<any, any> | null;
sortable?: boolean;
filters?: string[];
Expand Down
Loading