Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Term Entry] PyTorch Tensor Operations: .take_along_dim() #5951

Merged
merged 11 commits into from
Jan 20, 2025
Merged

[Term Entry] PyTorch Tensor Operations: .take_along_dim() #5951

merged 11 commits into from
Jan 20, 2025

Conversation

muhammedazhar
Copy link
Contributor

Description

  • Added torch.take_along_dim() documentation entry for PyTorch

Issue Solved

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@muhammedazhar muhammedazhar reopened this Jan 15, 2025
@dakshdeepHERE dakshdeepHERE self-assigned this Jan 15, 2025
@dakshdeepHERE dakshdeepHERE added python Python entries new entry New entry or entries status: under review Issue or PR is currently being reviewed pytorch PyTorch and removed python Python entries labels Jan 15, 2025
@dakshdeepHERE dakshdeepHERE linked an issue Jan 17, 2025 that may be closed by this pull request
[Term Entry] PyTorch Tensor Operations: .take_along_dim() #5926
Closed
3 tasks
dakshdeepHERE
dakshdeepHERE requested changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few comments for you to work on @muhammedazhar. Apart from that this looks good.

@muhammedazhar
Copy link
Contributor Author

Thank you for your detailed review. I will update these right away.

@muhammedazhar
Copy link
Contributor Author

I have implemented the requested changes as per the previous discussion. I believe the documentation is now complete for the merging. I appreciate your time and consideration in reviewing the changes.

dakshdeepHERE
dakshdeepHERE approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @muhammedazhar, for implementing the changes and this looks good for second review.

@Sriparno08 Sriparno08 self-assigned this Jan 20, 2025
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jan 20, 2025
Sriparno08
Sriparno08 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @muhammedazhar!

@Sriparno08 Sriparno08 merged commit 3892635 into Codecademy:main Jan 20, 2025
7 checks passed
@github-actions GitHub Actions
Copy link

👋 @muhammedazhar
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/pytorch/tensor-operations/take-along-dim

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sriparno08 Sriparno08 Sriparno08 approved these changes

@dakshdeepHERE dakshdeepHERE dakshdeepHERE approved these changes

Assignees

@Sriparno08 Sriparno08

@dakshdeepHERE dakshdeepHERE

Labels
new entry New entry or entries pytorch PyTorch status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Term Entry] PyTorch Tensor Operations: .take_along_dim()
4 participants
@muhammedazhar @CLAassistant @Sriparno08 @dakshdeepHERE