-
-
Notifications
You must be signed in to change notification settings - Fork 94
Fix #1505 : updated contributors shortcode to use try and Value pattern for … #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy request for cyf-curriculum pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-piscine pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-common pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-itd pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-launch pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-tracks pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-sdc pending review.Visit the deploys page to approve it
|
Hi! Thanks so much for putting this together! Can I ask how you tested out whether it's working? I tried to run this locally, but I can't find a version of Hugo this works with (136/140 complain that If Hugo made this as a breaking change ("You need to update right now"), we may need to either update all uses of But if Hugo left a way for both So - how did you test this out (e.g. what Hugo version did you use)? If you haven't tested it out, I'd recommend testing it out - make sure one of the sites (e.g. |
Hi . So, Hugo made this as a breaking change. I ran this locally for only one site that is Is there a way to test all the sites in one go? |
Well that's not very friendly of them! Unfortunately there wasn't a quick/easy way to check all the sites, so I just added one in #1514 - if you run Thank you! |
…Hugo v0.141+
What does this change?
This changes the contribute.html to match with the latest try value pattern in Hugo v0.141+
Common Content?
No
Common Theme?
Issue number: #1505
Org Content?
Checklist
Who needs to know about this?
@illicitonion
PS: This is my first PR on GitHub — I'm pretty excited to contribute to the cause! 🙌
Please feel free to guide me if I’ve missed anything or done something incorrectly.