Skip to content

Fix #1505 : updated contributors shortcode to use try and Value pattern for … #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hash-noob
Copy link

…Hugo v0.141+

What does this change?

This changes the contribute.html to match with the latest try value pattern in Hugo v0.141+

Common Content?

No

  • Block/s

Common Theme?

  • Yes

Issue number: #1505

Org Content?

Checklist

Who needs to know about this?

@illicitonion

PS: This is my first PR on GitHub — I'm pretty excited to contribute to the cause! 🙌
Please feel free to guide me if I’ve missed anything or done something incorrectly.

Copy link

netlify bot commented Jul 19, 2025

👷 Deploy request for cyf-curriculum pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ff9f30a

Copy link

netlify bot commented Jul 19, 2025

👷 Deploy request for cyf-piscine pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ff9f30a

Copy link

netlify bot commented Jul 19, 2025

👷 Deploy request for cyf-common pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ff9f30a

Copy link

netlify bot commented Jul 19, 2025

👷 Deploy request for cyf-itd pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ff9f30a

Copy link

netlify bot commented Jul 19, 2025

👷 Deploy request for cyf-launch pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ff9f30a

Copy link

netlify bot commented Jul 19, 2025

👷 Deploy request for cyf-tracks pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ff9f30a

Copy link

netlify bot commented Jul 19, 2025

👷 Deploy request for cyf-sdc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ff9f30a

@illicitonion
Copy link
Member

Hi! Thanks so much for putting this together! Can I ask how you tested out whether it's working?

I tried to run this locally, but I can't find a version of Hugo this works with (136/140 complain that try doesn't exist, and 141 complains that .Err doesn't exist), so I'm not sure how to test it locally.

If Hugo made this as a breaking change ("You need to update right now"), we may need to either update all uses of GetRemote to use try, or at least remove the others for one-off testing to help us make sure one is working before we apply the change elsewhere.

But if Hugo left a way for both try and .Err to work (at least to test in a transition), that'd be handy.

So - how did you test this out (e.g. what Hugo version did you use)? If you haven't tested it out, I'd recommend testing it out - make sure one of the sites (e.g. org-cyf-itp) works for you locally, and I can take a look when it works there!

@hash-noob
Copy link
Author

Hi . So, Hugo made this as a breaking change.
Reference : gohugoio/hugo#13216

I ran this locally for only one site that is org-cyf. My bad, since the change was in common-theme. I thought all the sites would use that same file and have no issues. I will check and update all GetRemote with try.

Is there a way to test all the sites in one go?

@illicitonion
Copy link
Member

Well that's not very friendly of them!

Unfortunately there wasn't a quick/easy way to check all the sites, so I just added one in #1514 - if you run ./tooling/build_all_sites.sh it will try building them all :)

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

2 participants