London| SDC-N0v-25| Ikenna Agulobi | Sprint 5| Laptop allocation #313
+104
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ike-agu
added
the
Needs Review
OracPrime
added
the
Review in progress
OracPrime
reviewed
Jan 11, 2026
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
The code is generally very good and has some nice touches in terms of normalization etc. However your algorithm doesn't scale. Can you think of a "good enough" rather than perfect one that does scale?
| @@ -0,0 +1,104 @@ | |||
| from dataclasses import dataclass | |||
| from enum import Enum | |||
| from typing import List, Dict, Optional, Tuple | |||
There was a problem hiding this comment.
I suspect you started using a Tuple and changed it to a List? It's good practice to remove unwanted imports.
|
|
||
| # =====define parse operating system====== | ||
| def parse_operating_system(raw: str) -> OperatingSystem: | ||
| normalized = raw.strip().lower() |
|
|
||
| if normalized not in aliases: | ||
| valid = ", ".join(sorted(aliases.keys())) | ||
| print(f"Error: invalid operating system. Try one of: {valid}", file=sys.stderr) |
There was a problem hiding this comment.
Like the inclusion of allowed values in the error message. Like the fact that you're using stderr
| best_assignment: Optional[Dict[Person, Laptop]] = None | ||
| best_total_sadness: Optional[int] = None | ||
|
|
||
| for chosen_laptops in itertools.combinations(laptops, len(people)): |
There was a problem hiding this comment.
This will work for 5 laptops. What happens if you've got 20 laptops?
OracPrime
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR contains the Laptop allocation exercise of sprint 5