Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 5 |implement laptop allocation #292
+89
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahwaZeslusHaile
added
the
Needs Review
OracPrime
added
the
Review in progress
OracPrime
reviewed
Jan 11, 2026
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
You need an algorithm that scales. This one doesn't
| best_assignment = None | ||
| lowest_sadness = float("inf") | ||
|
|
||
| for perm in permutations(laptops): |
There was a problem hiding this comment.
I think you need to revisit this algorithm. If you have 20 laptops, how many iterations is this loop?
| Laptop(4, "Apple", "MacBook Air", 13, OperatingSystem.MACOS), | ||
| Laptop(5, "Apple", "MacBook Pro", 16, OperatingSystem.MACOS), | ||
| Laptop(6, "Dell", "Latitude", 15, OperatingSystem.ARCH), | ||
| Laptop(7, "HP", "EliteBook", 13, OperatingSystem.MACOS), |
| @@ -1 +1,2 @@ | |||
| node_modules | |||
| .venv | |||
There was a problem hiding this comment.
While it's correct to gitignore .venv, if you've had to create a venv you should probably commit a requirements.txt that describes it.
OracPrime
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 5 |implement laptop allocation
Learners, PR Template
Self checklist
Changelist
Implement laptop allocation algorithm and detailed output
Questions
This solution is good for small data, but it doesn't scale because permutations grow factorially. The SciPy/Hungarian way to solve the problem is polynomial time and stays fast even with more laptops/people. Which approach do you prefer for this version?
Please review my work — thank you!