Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 5| Prep Exercises #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahwaZeslusHaile
added
the
Needs Review
OracPrime
reviewed
Jan 11, 2026
OracPrime
left a comment
OracPrime
left a comment
There was a problem hiding this comment.
Couple of minor tweaks required, but mostly very good
| return counts | ||
|
|
||
| def main(): | ||
| name = input("Enter your name: ").strip() |
There was a problem hiding this comment.
I'm liking the use of strip on inputs
| name: str | ||
| age: int | ||
| children: List["Person"] | ||
| fatma = Person(name="Fatma", age=5, children=[]) |
There was a problem hiding this comment.
Blank lines before and after the class declaration might make the code easier to read
| total += pence | ||
| return total | ||
| def format_pence_as_string(total_pence: int) -> str: | ||
| if total_pence < 100: |
There was a problem hiding this comment.
As mentioned in the meeting on Saturday, this code doesn't do what you want if total_pence is <-100
| age: int | ||
| preferred_operating_systems: List[str] | ||
| @dataclass(frozen=True) | ||
| class Laptop: |
There was a problem hiding this comment.
Again, some blank lines would be good for readability
OracPrime
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 5| Prep Exercises
Learners, PR Template
Self checklist
Changelist
Questions
Thank you for your time reviewing this work