London | 25-SDC-July | Franklin Kamela | Sprint 4 | Feature/shell-tools-python

[Fradoka]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Questions

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

[LonMcGregor]

Remember to update the default PR text when submitting on github.

Good start on this sprint's tasks, I have spotted a few areas where you could improve code further

[LonMcGregor]

Have you tested that the numbering is working correctly when multiple files are passed in?

[LonMcGregor]

Have you tested to make sure your -1 argument is working correctly?

[LonMcGregor]

There is some duplication in this code, can you have a look at reducing it?

Also, when you are outputting, make sure that the indentation is working right.

[github-actions]

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

[Fradoka]

Hi @LonMcGregor, i have now addressed the reviews.

[LonMcGregor]

Good work reducing the duplication in wc, and while the column-printing solution in ls might be a bit more complicated than is necessary for this task, that's good practice, well done.

In cat I have the same comment as I made in your js implementation - is it necessary to count line numbers and non blank line numbers separately?

[Fradoka]

hi @LonMcGregor, i dont actually have to use 2 separate counters. i have now amended the code code to let -b overide -n like in real cat and used only 1 counter to address review.

[LonMcGregor]

Great work