Glasgow | 25-SDC-July | Aiah Ibrahim | Sprint 4 | Implement cowsay in Python#149
Open
aiahibrahim wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Glasgow | 25-SDC-July | Aiah Ibrahim | Sprint 4 | Implement cowsay in Python#149aiahibrahim wants to merge 1 commit intoCodeYourFuture:mainfrom
aiahibrahim wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
aiahibrahim
added
the
Needs Review
illicitonion
changed the title
DaryaShirokova
added
Review in progress
DaryaShirokova
approved these changes
Aug 17, 2025
DaryaShirokova
left a comment
DaryaShirokova
left a comment
There was a problem hiding this comment.
LGTM! Just a small optional comment.
Comment on lines
+27
to
+28
| say_function = getattr(cowsay, args.animal) | ||
| say_function(message) |
There was a problem hiding this comment.
You could use get_output_string instead, I'd generally avoid using reflection methods like getattr if there are alternatives as they harm readability: https://pypi.org/project/cowsay/
DaryaShirokova
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.