London | 25-SDC-July | Andrei Filippov | Sprint 4 | Implement shell tools in Python #142

Droid-An · 2025-08-03T11:21:24Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Implemented shell tools in Python

Questions

what formatter to use for python?

LonMcGregor

Good start on these implementations - I've left a comment on each file with a pointer to show you where you could improve them.

For your question about formatters what do you mean - formatting your code or formatting strings?

You can use any code formatter (or none at all), as long as you are consistent with the code you commit
Python has a few ways to do string formatting, the newest versions of python have something called "f-strings" that are very powerful, but might take a lot of time to learn fully

LonMcGregor · 2025-08-19T10:09:16Z

implement-shell-tools/cat/cat.py

+for path in args.path:
+    with open(path) as file:
+        lines = file.readlines()
+        line_num = 1


When printing out the line numbers, compare how the original cat application works to yours. Do you see any discrepancies?

The only discrepancies I see are in spacing. Is that acceptable, provided the output is correct?

LonMcGregor · 2025-08-19T10:11:49Z

implement-shell-tools/ls/ls.py

+path_proceeding(args.path)
+
+
+


This is a very minor remark, but try not to leave lots of blank lines throughout the file, like here at the end.

Noted, thank you

Thanks for fixing this

LonMcGregor · 2025-08-19T10:14:49Z

implement-shell-tools/wc/wc.py

+        total.append(output.copy())
+    output.append(path)
+    string_list = map(str, output)
+    print("       ".join(string_list))


Can you see any problem that might happen with the displayed spacing of the output?

honestly, no

LonMcGregor

For cat, try running the original cat program with the -nargument, with multiple files using a wildcard, and then run your own. Can you see any differences?
Can you see any issues with the alignment of columns if you run ẁc`with multiple files using a wildcard?

Droid-An · 2025-09-07T17:56:07Z

I saw difference in spacing, so I added more space to output. Also I aligned numbers to the right and padded with spaces on the left.
yes, numbers in output were not right-aligned; they were left-aligned with inconsistent spacing. I fixed it by applying rjust method before printing

github-actions · 2025-09-07T17:56:34Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

github-actions · 2025-09-07T17:56:37Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

LonMcGregor

Good work, I think you are almost there with this implementation.

LonMcGregor · 2025-09-08T09:04:53Z

implement-shell-tools/cat/cat.py

+    if os.path.isfile(path):
+        with open(path) as file:
+            lines = file.readlines()
+            line_num = 1


If I pass in multiple files the numbering still isn't quite working right here. Think about when you might want to use cat with multiple files, and why you might number the lines. How should the application behave in those cases?

Sorry, I’m not sure what part isn’t working. When I run the cat command in the console with the -n flag and multiple files, I get this output:

cyf@cyfs-MacBook-Pro cat % cat -n sample-files/*.txt 1 Once upon a time... 1 There was a house made of gingerbread. 1 It looked delicious. 2 I was tempted to take a bite of it. 3 But this seemed like a bad idea... 4 5 There's more to come, though...

When I run the same with my command, I get the same result:

cyf@cyfs-MacBook-Pro cat % python3 cat.py -n sample-files/*.txt 1 Once upon a time... 1 There was a house made of gingerbread. 1 It looked delicious. 2 I was tempted to take a bite of it. 3 But this seemed like a bad idea... 4 5 There's more to come, though...

LonMcGregor · 2025-09-08T09:07:38Z

implement-shell-tools/wc/wc.py

+        output_for_one_file.append(file_size)
+
+    if len(args.path) > 1:
+        numbers.append(output_for_one_file.copy())


Is this variable intended to help store totals? Is "numbers" a good variable name for this?

github-actions · 2025-09-08T09:11:48Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

github-actions · 2025-09-08T09:11:51Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

Droid-An added 5 commits August 1, 2025 16:58

wip: done -1 flag

5f53628

done ls

66d8f5e

removed unnecessary comments and created wc.py file

573074c

done wc

ace3d8e

done cat

0ddafe8

Droid-An added 📅 Sprint 4 Assigned during Sprint 4 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 3, 2025

LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 19, 2025

LonMcGregor reviewed Aug 19, 2025

View reviewed changes

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 19, 2025

done changes according to review

8544e56

Droid-An added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 20, 2025

LonMcGregor reviewed Aug 25, 2025

View reviewed changes

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 25, 2025

Droid-An added 4 commits September 7, 2025 13:41

fixed cat

f9ea264

fixed wc

5ddd011

done changes according to review

350c3f2

added right-justify to output

f8941fb

Droid-An added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 7, 2025

LonMcGregor reviewed Sep 8, 2025

View reviewed changes

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 8, 2025

Applied review changes

f654716

Droid-An added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 12, 2025

		path_proceeding(args.path)

Uh oh!

London | 25-SDC-July | Andrei Filippov | Sprint 4 | Implement shell tools in Python #142

Are you sure you want to change the base?

London | 25-SDC-July | Andrei Filippov | Sprint 4 | Implement shell tools in Python #142

Uh oh!

Conversation

Droid-An commented Aug 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Droid-An commented Sep 7, 2025

Uh oh!

github-actions bot commented Sep 7, 2025

Uh oh!

github-actions bot commented Sep 7, 2025

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

Uh oh!

Droid-An commented Aug 3, 2025 •

edited

Loading