Glasgow | 26-ITP-Jan| Martin McLean | Sprint 1 | coursework#955
Open
mjm-git185 wants to merge 8 commits intoCodeYourFuture:mainfrom
Open
Glasgow | 26-ITP-Jan| Martin McLean | Sprint 1 | coursework#955mjm-git185 wants to merge 8 commits intoCodeYourFuture:mainfrom
mjm-git185 wants to merge 8 commits intoCodeYourFuture:mainfrom
Conversation
mjm-git185
added
the
Needs Review
WeiTsungCheng
added
Review in progress
Sprint-1/1-key-exercises/3-paths.js
Outdated
| const dir = ; | ||
| const ext = ; | ||
| const firstSlashIndex = filePath.indexOf("/"); | ||
| const dir = filePath.slice(firstSlashIndex + 1, lastSlashIndex - 1); |
Sprint-1/2-mandatory-errors/4.js
Outdated
|
|
||
| let twelveHourClockTime = "20:53"; | ||
| let twelthHour = twelveHourClockTime.substring(0, twelveHourClockTime.length -3); | ||
| if (twelthHour >12) {twelthHour = twelthHour - 12}; |
There was a problem hiding this comment.
The specific time period was not taken into account; it is recommended to conduct some conversion tests for different time periods.
There was a problem hiding this comment.
12:xx PM should still be 12:xx
12:xx AM should be 00:xx
There was a problem hiding this comment.
another thing is
13.00 should use ":" not "."
| // For the piece of code above, read the code and then answer the following questions | ||
|
|
||
| // a) How many variable declarations are there in this program? | ||
| // there are 6 declarations |
| @@ -1,4 +1,4 @@ | |||
| const movieLength = 8784; // length of movie in seconds | |||
| const movieLength = 4; // length of movie in seconds | |||
There was a problem hiding this comment.
why change the length from 8784 to 4
Author
There was a problem hiding this comment.
i was trying a bunch of different values to see how it would handle smaller Numbers have changed it back to the original value now tho
WeiTsungCheng
added
Reviewed
mjm-git185
added
the
Needs Review
There was a problem hiding this comment.
12:xx PM should still be 12:xx
12:xx AM should be 00:xx
There was a problem hiding this comment.
nice!
almost correct!
Please confirm that one of them is missing a "/"
WeiTsungCheng
removed
the
Needs Review
mjm-git185
added
the
Needs Review
Sprint-1/2-mandatory-errors/4.js
Outdated
| let sufix =".AM" | ||
|
|
||
|
|
||
| if (twelthHour => 13) { |
Sprint-1/1-key-exercises/3-paths.js
Outdated
| const dir = ; | ||
| const ext = ; | ||
| const firstSlashIndex = filePath.indexOf("/"); | ||
| const dir = filePath.slice(firstSlashIndex + 1, lastSlashIndex +1); |
There was a problem hiding this comment.
dir should be '/Users/mitch/cyf/Module-JS1/week-1/interpret'
There was a problem hiding this comment.
another thing is
13.00 should use ":" not "."
WeiTsungCheng
removed
the
Needs Review
mjm-git185
added
the
Needs Review
WeiTsungCheng
approved these changes
Feb 19, 2026
WeiTsungCheng
removed
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
i have compleaed my course work now