Skip to content

London | 25_ITP-Sept | Samuel Tarawally | Sprint 2 | Coursework #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

London | 25_ITP-Sept | Samuel Tarawally | Sprint 2 | Coursework #820

wants to merge 11 commits into from

Conversation

@Tarawally
Copy link

@Tarawally Tarawally commented Oct 29, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • 1-key-errors: Fixed parameter redeclaration errors, invalid parameter syntax, and scope issues
  • 2-mandatory-debug: Debugged missing return statements, unreachable code, and missing function parameters
  • 3-mandatory-implement: Implemented BMI calculator, UPPER_SNAKE_CASE converter, and reusable pence-to-pounds function
  • 4-mandatory-interpret: Analysed helper functions, execution flow, and return values in time formatting

@Tarawally Tarawally added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 29, 2025
@Tarawally Tarawally linked an issue Nov 3, 2025 that may be closed by this pull request
02 Complete Sprint 2 coursework Tarawally/My-Coursework-Planner#50
Open
cjyuan
cjyuan reviewed Nov 6, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Well done!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

02 Complete Sprint 2 coursework

2 participants

@Tarawally @cjyuan