London | 25-ITP-Sep | Shaghayegh Shirinfar | Sprint 3 | Implement-and-rewrite-tests #817
Conversation
shaghayeghfar
added
the
Needs Review
Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
Outdated
Show resolved
Hide resolved
| const num = Number(rank); | ||
| if (num >= 2 && num <= 9) { | ||
| return num; | ||
| } |
There was a problem hiding this comment.
In JavaScript, strings that represent valid numeric literals in the language can be safely
converted to equivalent numbers or parsed into a valid integers.
Do you want to recognize these string values as valid ranks?
To find out what these strings are, you can ask AI
What kinds of string values would make
Number(rank)evaluate to2in JS?
There was a problem hiding this comment.
I did the changes in the code since we just need specific number and letters in our exercise.
thank you for your help
| // Case 5: Negative denominator | ||
| test("should return true when denominator is negative and proper", () => { | ||
| expect(isProperFraction(2, -5)).toEqual(true); | ||
| }); |
There was a problem hiding this comment.
Can your function pass this test?
There was a problem hiding this comment.
I change my code
from if (Math.abs(numerator) < (denominator))
to if (Math.abs(numerator) < Math.abs(denominator))
so that it also works with negative denominators.
| test("should return true for a negative proper fraction (numerator < denominator)", () => { | ||
| expect(isProperFraction(-4, 7)).toEqual(true); | ||
| }); |
There was a problem hiding this comment.
What about negative improper fraction?
There was a problem hiding this comment.
I made some changes to the is-proper-fraction function , it works correctly now.
Thank you for your guides
cjyuan
added
Reviewed
|
Dear Cj |
2 participants
Learners, PR Template
Self checklist