West Midlands | Sept-ITP-25 | Mustaf Asani | Sprint 3 | Coursework/sprint 3 practice tdd #813
Conversation
…he function that checks for that
…get the ordinal numbers
…t takes in a string and count to create a new string
asaniDev
added
the
Needs Review
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| let pattern = new RegExp(findCharacter, "g"); | ||
|
|
||
| let matchingChars = stringOfCharacters.match(pattern); | ||
|
|
||
| if (matchingChars === null) { | ||
| return 0; | ||
| } | ||
|
|
||
| return matchingChars.length; | ||
| } |
There was a problem hiding this comment.
Does your function returns the value you expect in the following function calls?
countChar("=^.^=", "^");
countChar("=^.^=", ".");
| if (num === 1) { | ||
| return "1st"; | ||
| } else if (num === 2) { | ||
| return "2nd"; | ||
| } else if (num === 3) { | ||
| console.log(num); | ||
| return "3rd"; | ||
| } else if (num > 3 || num < 21) { | ||
| return `${num}th`; | ||
| } |
There was a problem hiding this comment.
-
For best practices, code submitted to review should be free of debugging code (to keep the code clean).
-
What should the ordinal numbers of 103, 213, 31 be?
| test("should return '2nd' for 2", () => { | ||
| expect(getOrdinalNumber(2)).toEqual("2nd"); | ||
| }); | ||
|
|
||
| test("should return '3rd' for 3", () => { | ||
| expect(getOrdinalNumber(3)).toEqual("3rd"); |
There was a problem hiding this comment.
To ensure thorough testing, we need broad scenarios that cover all possible cases.
Listing individual values, however, can quickly lead to an unmanageable number of test cases.
Instead of writing tests for individual numbers, consider grouping all possible input values into meaningful categories.
Then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain.
For example, we can prepare a test for numbers 2, 22, 132, etc. as
test("append 'nd' to numbers ending in 2, except those ending in 12", () => {
expect( getOrdinalNumber(2) ).toEqual("2nd");
expect( getOrdinalNumber(22) ).toEqual("22nd");
expect( getOrdinalNumber(132) ).toEqual("132nd");
});
Can you make the tests in this script more comprehensive?
| if (count === 0) { | ||
| return newStr; | ||
| } else if (count === 1) { | ||
| return (newStr += str); |
There was a problem hiding this comment.
Why not just return str directly?
| } else { | ||
| return "Error invalid count used, please use integers from 0 upwards."; | ||
| } |
There was a problem hiding this comment.
How would the caller distinguish the result of the following two function calls?
repeat("Error invalid count used, please use integers from 0 upwards.", 1)repeat("", -1)
Both function calls return the same value.
| expect(repeatedStr).toEqual( | ||
| "Error invalid count used, please use integers from 0 upwards." | ||
| ); |
There was a problem hiding this comment.
If you modified repeat() to throw an error when count is negative, and you wanted to test if the function can throw an error as expected, you can use .toThrow(). You can find out more about how to use .toThrow() here: https://jestjs.io/docs/expect#tothrowerror (Note: Pay close attention to the syntax of the example)
cjyuan
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
Created tests to check the expected output of functions before they are created.