Birmingham | 25-ITP-Sept | Khor Biel | Sprint 3 | coursework/sprint-3-implement-and-rewrite #797

wankoak · 2025-10-23T09:19:34Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Added Jest test files for angle type, proper fraction, and card value functions

No questions

… functions

github-actions · 2025-10-23T09:19:57Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan · 2025-10-27T15:22:18Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

+  // Handle invalid denominators (e.g., divide by zero)
+  if (denominator === 0) {
+    return false;
+  }
+
+  // Compare absolute values for proper fraction check
+  if (Math.abs(numerator) < Math.abs(denominator)) {
    return true;
+  } else {
+    return false;
  }


This solution is correct. If you are up to some challenge, try simplify the code to use at most one if-statement.

cjyuan · 2025-10-27T15:26:41Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+  if (!isNaN(rank) && Number(rank) >= 2 && Number(rank) <= 9) {
+    return Number(rank);
+  }


In JavaScript, strings that represent valid numeric literals in the language can be safely
converted to equivalent numbers or parsed into a valid integers.
Do you want to recognize these string values as valid ranks?

To find out what these strings are, you can ask AI

What kinds of string values would make Number(rank) evaluate to 2 in JS?

cjyuan · 2025-10-27T15:29:02Z

The PR description is missing a "Changelist' section with a brief description of the changes made in PR.

github-actions · 2025-10-29T07:19:32Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-29T07:22:50Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

wankoak · 2025-10-29T08:46:01Z

@cjyuan I fixed some errors that you mentioned

github-actions · 2025-10-29T08:46:36Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-29T08:49:02Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-29T10:25:26Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan

The bot's message "Your PR description contained template fields" refers to the placeholder text "Briefly explain your PR" in the PR description. The bot expects you to delete it after you typed your brief description.

cjyuan · 2025-10-29T11:21:06Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+  }  else if ((parseInt(rank) >= 2 && parseInt(rank)) && parseInt(rank) < 11){
+    return parseInt(rank)
+  }


Can you find out from AI what strings can make the expression ((parseInt(rank) >= 2 && parseInt(rank)) && parseInt(rank) < 11) evaluate to true?

Should all of these strings be recognized as valid rank?

Also, what's the purpose of (... && parseInt(rank))?

cjyuan · 2025-10-29T11:23:15Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+  }  else if ((parseInt(rank) >= 2 && parseInt(rank)) && parseInt(rank) < 11){
+    return parseInt(rank)
+  }
+  else if( rank === "J" || rank === "Q" || rank === "K") {


What you had before is equally good.

if (["K", "Q", "J", "10"].includes(rank)) {

cjyuan · 2025-10-29T11:24:48Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
+  let rank = card.slice(0, card.length - 1);


Why replaced const rank = card.slice(0, -1);?

github-actions · 2025-10-29T11:25:36Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-29T11:25:39Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Added Jest test files for angle type, proper fraction, and card value…

3934b5d

… functions

wankoak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 23, 2025

cjyuan reviewed Oct 27, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 27, 2025

Made small test with jest changes

ced98d6

wankoak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 29, 2025

wankoak removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Oct 29, 2025

cjyuan reviewed Oct 29, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2025

Uh oh!

Uh oh!

Birmingham | 25-ITP-Sept | Khor Biel | Sprint 3 | coursework/sprint-3-implement-and-rewrite #797

Are you sure you want to change the base?

Birmingham | 25-ITP-Sept | Khor Biel | Sprint 3 | coursework/sprint-3-implement-and-rewrite #797

Uh oh!

Conversation

wankoak commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

cjyuan Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Oct 27, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

wankoak commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wankoak commented Oct 23, 2025 •

edited

Loading