Skip to content

London | 25-ITP-SEP | Imran Mohamed| Sprint 3 | Coursework/sprint 3 implement and rewrite #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

London | 25-ITP-SEP | Imran Mohamed| Sprint 3 | Coursework/sprint 3 implement and rewrite #791

wants to merge 7 commits into from
+3,550 −11

Conversation

@i786m
Copy link

@i786m i786m commented Oct 22, 2025 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have coded the respective functions, assertions and tests for this portion of coursework

@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@i786m i786m changed the title London | 25- | Imran Mohamed| Sprint 3 | Coursework/sprint 3 implement and rewrite London | 25-ITP-SEP | Imran Mohamed| Sprint 3 | Coursework/sprint 3 implement and rewrite Oct 22, 2025
@i786m i786m added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 22, 2025
A-O-Emmanuel
A-O-Emmanuel reviewed Oct 26, 2025
View reviewed changes
Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
Copy link

@A-O-Emmanuel A-O-Emmanuel Oct 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your implementation of the getAngleType function is logically correct, and follow TDD principles good work

@A-O-Emmanuel A-O-Emmanuel added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025
A-O-Emmanuel
A-O-Emmanuel reviewed Oct 26, 2025
View reviewed changes
Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
}
if(numerator == 0){
return true;
}
Copy link

@A-O-Emmanuel A-O-Emmanuel Oct 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should review the acceptance criteria again for this one and look at the explanation

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a stretch scenario I created, I have updated the code to ensure the condition also checks that the denominator is non-zero.
Please let me know if this is sufficient.

@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 26, 2025
@i786m i786m added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 28, 2025
@i786m i786m requested a review from A-O-Emmanuel October 28, 2025 11:02
@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@A-O-Emmanuel A-O-Emmanuel Awaiting requested review from A-O-Emmanuel

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@i786m @A-O-Emmanuel