Rework sprint 3 assignments #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously they were: 1. Very repetitive, having the trainees solve the same problem more than once which was confusing and not a great use of time. 2. Large. Reviewing the whole PR for the sprint took a long time, so was very daunting for reviewers, and led to review backlogs. 3. Hard to track who was doing the stretch, because it was maybe in the same PR or just maybe missing from the PR. Instead: 1. Re-use their implementation for both sets of tests - this emphasises also that the point of the exercise is writing tests different ways. 2. Split off the practice-tdd and stretch into their own expected separate PRs. 3. Fix up a bunch of inconsistent formatting.
This comment was marked as resolved.
This comment was marked as resolved.
| https://code.visualstudio.com/docs/editor/testing | ||
|
|
||
| 1. Go to rewrite-tests-with-jest/1-get-angle-type.test.js | ||
| 1. Click the green play button to run the test. It's on the left of the test function in the gutter. |
There was a problem hiding this comment.
Suggested change
| 1. Click the green play button to run the test. It's on the left of the test function in the gutter. | |
| 2. Click the green play button to run the test. It's on the left of the test function in the gutter. |
|
|
||
| 1. Go to rewrite-tests-with-jest/1-get-angle-type.test.js | ||
| 1. Click the green play button to run the test. It's on the left of the test function in the gutter. | ||
| 1. Read the output in the TEST_RESULTS tab at the bottom of the screen. |
There was a problem hiding this comment.
Suggested change
| 1. Read the output in the TEST_RESULTS tab at the bottom of the screen. | |
| 3. Read the output in the TEST_RESULTS tab at the bottom of the screen. |
| 1. Go to rewrite-tests-with-jest/1-get-angle-type.test.js | ||
| 1. Click the green play button to run the test. It's on the left of the test function in the gutter. | ||
| 1. Read the output in the TEST_RESULTS tab at the bottom of the screen. | ||
| 1. Explore all the tests in this repo by opening the TEST EXPLORER tab. The logo is a beaker. |
There was a problem hiding this comment.
Suggested change
| 1. Explore all the tests in this repo by opening the TEST EXPLORER tab. The logo is a beaker. | |
| 4. Explore all the tests in this repo by opening the TEST EXPLORER tab. The logo is a beaker. |
|
Pushed fixes to the bullet points in 8f3d6cf :) Thanks @jenny-alexander! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously they were:
Instead: