London | May 2025 | Houssam Lahlah | Acoursework/sprint 2 #672

HoussamLh · 2025-07-20T19:58:06Z

Check List

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist :

This PR contains solutions for the Sprint 2 coursework exercises:

key-errors:
Implemented capitalise, convertToPercentage, and fixed square function errors.

mandatory-debug:
Debugged and fixed multiply, sum, and getLastDigit functions.

mandatory-implement:
Implemented calculateBMI, converted strings to upper case, and created reusable toPounds function.

mandatory-interpret:
Added formatTimeDisplay function to convert seconds into HH:MM:SS format.

stretch-extend:
Extended formatAs12HourClock function with edge case handling and added tests.

All functions have been tested with relevant inputs to ensure correctness.

Questions

Is my use of descriptive commit messages clear and helpful for reviewers?

Are there any improvements I could make in code style or function structure based on the style guide?

…dle, and last names.

…om file path string using slice.

…ween minimum and maximum.

…tion.

…vertToPercentage

…nt value

cjyuan · 2025-07-20T22:15:33Z

You made some changes to the "Sprint-1" folder in your main branch. As a result, when you created the acoursework/sprint-2 branch from main, it inherited those changes. However, the updates in the "Sprint-1" folder are unrelated to the Sprint-2 exercise.

Can you revert the changes made in the "Sprint-1" folder?
One way to "revert the changes" in the "Sprint-1" folder is to replace the "Spint-1" folder in this branch by the "Sprint-1" folder from CYF's main branch: https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/tree/main

You can download CYF's main branch as a ZIP file and then copy/paste the "Sprint-1" folder from the ZIP file to your branch.

Note: Your acoursework/sprint-3 branch is also affected in the similar way.

cjyuan

Code is good and explanation is clear.

Some of the code could use some improvement.

cjyuan · 2025-07-20T22:26:49Z

Sprint-2/3-mandatory-implement/3-to-pounds.js

+  const pounds = kg * 2.20462;
+  return pounds.toFixed(2); // rounds to 2 decimal places


The pounds refer to the British currency.
This exercise the objective is to rewrite the code in Sprint-1/3-mandatory-interpret/3-to-pounds.js as a function.

Thank you for the feedback. I understand now that the exercise is about converting pence to British pounds, not kilograms to pounds.

I rewrite the code in Sprint-1/3-mandatory-interpret/3-to-pounds.js as a function that takes a pence string (like "399p") and returns the formatted pounds (like "£3.99"), then test it with different inputs.

Let me know if I’ve understood it correctly.

Sprint-2/5-stretch-extend/format-time.js

cjyuan

Changes look good and good job in fixing the branch.

Your forgot to check these checkboxes

You haven't yet changed the label to "Needs review" but I assumed you have finished changing your code.

cjyuan · 2025-07-21T22:07:22Z

Sprint-2/5-stretch-extend/format-time.js

+    formattedHour = String(hours - 12).padStart(2, "0");
+    period = "pm";
+  } else {
+    formattedHour = String(hours).padStart(2, "0");
+    period = "am";
  }
-  return `${time} am`;
+
+  return `${formattedHour}:${minutes} ${period}`;


Could also consider format the hours with padStart(2, "0") at line 22 (at one location); less code and make code maintenance easier.

HoussamLh added 20 commits June 17, 2025 23:30

explain Increment count variable by 1 after initialization.

2dd0a78

Create initials variable by extracting first characters of first, mid…

1bc5c74

…dle, and last names.

create two variable and Extract directory and file extension parts fr…

b16d048

…om file path string using slice.

Add comments explaining how num is calculated as a random integer bet…

625c114

…ween minimum and maximum.

Add explanation for incrementing count variable by 1 after initializa…

f5522e7

…tion.

I believe that I've Done the sprint 1 and this the last exercise.

1cf3f70

I believe that I've completed the first sprint.

b76c5a3

I've changed const to let for age variable to allow reassignment

0748f7c

Avoid redeclaring 'str' inside capitalise function

d957dd1

Remove redeclaration of parameter and undefined variable usage in con…

fcba7aa

…vertToPercentage

Use valid parameter name instead of number in square function

c278bbb

Avoid redeclaring 'str' inside capitalise function

335cc37

Return value from multiply function instead of just logging it

2f9d4da

Correct return statement in sum function to return a + b

bdc5ac9

Update getLastDigit function to use input parameter instead of consta…

16d6577

…nt value

Implement calculateBMI function with 1 decimal rounding

8796b5b

Convert strings to UPPER_SNAKE_CASE format

1b5f2cf

Create reusable toPounds function with test cases

6573f60

Add inline comments explaining pad and formatTimeDisplay behaviour

01a1ced

Correct 12-hour clock formatting and add comprehensive tests

eeff899

HoussamLh added the Needs Review Participant to add when requesting review label Jul 20, 2025

cjyuan added the 👀 Review Git Changes requested to do with Git label Jul 20, 2025

cjyuan reviewed Jul 20, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 20, 2025

HoussamLh added 4 commits July 21, 2025 19:01

Revert Sprint-1 folder to CYF's original version

f39781a

Revert Sprint-1 folder to CYF's original version

bce599b

convert kg to pounds and round to 2 decimal places

19f296f

Create reusable toPounds function from Sprint-1 code

f63026f

format 12-hour time consistently with 2-digit hours

a9c2a21

cjyuan reviewed Jul 21, 2025

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed 👀 Review Git Changes requested to do with Git Reviewed Volunteer to add when completing a review labels Jul 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

London | May 2025 | Houssam Lahlah | Acoursework/sprint 2 #672

London | May 2025 | Houssam Lahlah | Acoursework/sprint 2 #672

Uh oh!

HoussamLh commented Jul 20, 2025 •

edited

Loading

Uh oh!

cjyuan commented Jul 20, 2025

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Jul 20, 2025

Uh oh!

HoussamLh Jul 21, 2025

Uh oh!

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Jul 21, 2025

Uh oh!

Uh oh!

		const pounds = kg * 2.20462;
		return pounds.toFixed(2); // rounds to 2 decimal places

Uh oh!

London | May 2025 | Houssam Lahlah | Acoursework/sprint 2 #672

Are you sure you want to change the base?

London | May 2025 | Houssam Lahlah | Acoursework/sprint 2 #672

Uh oh!

Conversation

HoussamLh commented Jul 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjyuan commented Jul 20, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

HoussamLh Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HoussamLh commented Jul 20, 2025 •

edited

Loading