Skip to content

London | May 2025 | Samuel Tarawally | Sprint 2 | Coursework #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

London | May 2025 | Samuel Tarawally | Sprint 2 | Coursework #668

wants to merge 18 commits into from

Conversation

Tarawally
Copy link

@Tarawally Tarawally commented Jul 19, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

  • Errors: Analysed and fixed SyntaxError and ReferenceError issues.
  • Debugging: Corrected logical errors in several functions.
  • Implementation: Created calculateBMI, toUpperSnakeCase, and toPounds functions.
  • Interpretation: Traced execution of a time-formatting script.

Tarawally added 18 commits July 14, 2025 23:41
@Tarawally
ignores local vscode configurations
46d1dd2
@Tarawally
docs(errors-0): Predict and explain error in capitalise function
4438f2d
@Tarawally
docs(errors-0): Predict and explain error in capitalise function
22e00ee
@Tarawally
docs(key-errors-1): Clarify explanations regarding variable redeclara…
c1fb283 
…tion and scope errors.
@Tarawally
docs(key-errors): cCarify error explanation in square function example.
7284a1f
@Tarawally
fix(0.js): Correct multiply function to return value
a0442d0
@Tarawally
fix(0.js): Correct multiply function to return value
fd5e2b5
@Tarawally
fix(0.js): Correct multiply function to return value
a215a26
@Tarawally
fix(1.js): correct sum function to return proper result and add expla…
3ec1c22 
…nation
@Tarawally
fix(mandatory-debug): update getLastDigit to use parameter instead of…
28d8815 
… global variable
@Tarawally
fix(errors): correct invalid function parameter name in square function
1d04ae1
@Tarawally
fix(errors): refactor error explanation and correct code for percenta…
9296d88 
…ge conversion
@Tarawally
fix(errors): resolve variable redeclaration error in capitalise function
fd53bfc
@Tarawally
feat(implement): calculate BMI rounded to one decimal place
3540425
@Tarawally
feat(implement): upper snake case conversion function
c38389a
@Tarawally
feat(implement): refactor pence conversion script into toPounds function
263d8c9
@Tarawally
docs(interpret): Answer questions in time-format.js
2348e1e
@Tarawally
Merge branch 'CodeYourFuture:main' into sprint-2
86c9dd3
@Tarawally Tarawally marked this pull request as draft July 19, 2025 14:54
@Tarawally Tarawally added the Needs Review Participant to add when requesting review label Jul 20, 2025
@Tarawally Tarawally marked this pull request as ready for review July 20, 2025 23:16
@Tarawally Tarawally linked an issue Jul 20, 2025 that may be closed by this pull request
02 Complete Sprint 2 coursework Tarawally/My-Coursework-Planner#18
Open
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 21, 2025
LonMcGregor
LonMcGregor reviewed Jul 21, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this sprint. You can close it now and move on to the next task.

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and review comments have been addressed and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

02 Complete Sprint 2 coursework
2 participants
@Tarawally @LonMcGregor