London | 25-ITP-May | Surafel Workneh | Data structure | Sprint 2 | #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate comments for clarity Sprint-2/1-key-errors/0.js
…xplain Sprint-2/1-key-errors/1.js
… parameter definition and error explanation in Sprint-2/1-key-errors/2.js
…d explain function for clarity in Sprint-2/2-mandatory-debug/0.js
… return the sum of two numbers and explain code for clarity in Sprint-2/2-mandatory-debug/1.js
…x getLastDigit function to correctly return the last digit of a number and update comments for clarity in Sprint-2/2-mandatory-debug/2.js
…hy it always returns '3' in Sprint-2/2-mandatory-debug/2.js
…sed on weight and height, including detailed comments for clarity in Sprint-2/3-mandatory-implement/1-bmi.js
…KE_CASE with example usage Sprint-2/3-mandatory-implement/2-cases.js
…tted pounds with example usage Sprint-2/3-mandatory-implement/3-to-pounds.js
…d pad() in sprint -2/ time-format.js
…ps of input data or edge cases as you can, and fix any bugs in Sprint-2/5-stretch-extend/format-time.js
Open
5 tasks
cjyuan
added
the
Review in progress
cjyuan
reviewed
Jul 19, 2025
| const BMI = weight / heightSquared; | ||
| // return the BMI to 1 decimal place | ||
| return BMI.toFixed(1); |
There was a problem hiding this comment.
What type of value do you expect the function to return? A number or a string?
Does your function return the type of value you expect it to return?
There was a problem hiding this comment.
fixed to return type to numbers
Comment on lines
19
to
26
| //split the string into an array of words | ||
| const wordsArray = string.split(" "); | ||
| // Convert each word to uppercase | ||
| const upperWordsArray = wordsArray.map((word) => word.toUpperCase()); | ||
| // Join the array back into a string with underscores | ||
| const toUpperSnakeCase = upperWordsArray.join("_"); | ||
| // Return the string in UPPER_SNAKE_CASE | ||
| return toUpperSnakeCase; |
There was a problem hiding this comment.
You could also apply toUpperCase() to the whole string before split or after join.
cjyuan
added
Reviewed
|
Changes look good. |
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.