WESTMIDLANDS | ITP-MAY-25 | AHMAD EHSAS | MODULE STRUCTURING AND TESTING DATA SPRINT-3 #656

ahmadehsas · 2025-07-12T15:26:18Z

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Completed sprint-3, dealing with errors and understanding the flow of a program

Questions

…feedback

…, and invalid cards

…he goal of this function is to count how many times a specific character appears in a given string

…successfully.

cjyuan

Can you revert the changes made to these two files (see pic) in Sprint-1 folder? They are not related to Sprint-3 exercise.

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

cjyuan · 2025-07-17T21:49:23Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

+  if (rank === "A") return 11;
+  if (["K", "Q", "J"].includes(rank)) return 10;
+
+  const number = parseInt(rank);


Does your function return the value you expected from each of the following function calls?

getCardValue("0x02♠"); getCardValue("2.1♠"); getCardValue("0002♠"); getCardValue("3ABC♠");

Consider looking up how parseInt() work.

Yes, the function returns the card value based on the card's rank.

Yes, the function returns a value based on the card's rank condition.

I've attached the screenshots.

parseInt() can return an integer but do you consider the values I suggested valid?

As parseInt() returns Integers, and the values with decimal numbers can only return an integer, not the decimal part. So technically, the values you suggested are valid in the sense that it doesn't cause an error. But it does not reflect the true value of the number. It truncates the decimal.

The objective of the function is to determine the value of the rank of a card.

If you were to design a card game, would you allow the card to be displayed as
"2.9999999999999999999999♠", "3AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA♠"?

cjyuan · 2025-07-17T21:50:09Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

+test("should return 5 for 5 of Hearts", () => {
+  const fiveofHearts = getCardValue("5♥");
+  expect(fiveofHearts).toEqual(5);
+});
+
+test("should return 10 for 10 of Diamonds", () => {
+  const tenofDiamonds = getCardValue("10♦");
+  expect(tenofDiamonds).toEqual(10);
+});


When preparing tests, we should ensure the tests cover all possible cases. If we specify a test for individual card, we will need about 53 tests to cover all possible cases. Instead, we could consider classifying all possible values into different categories, and then within each category we test some samples.

For example, one possible category for getCardValue() is, "should return the value of number cards (2-10)", and we can prepare the test as

test("should return the value of number cards (2-10)", () => { expect(getCardValue("2♣︎")).toEqual(2); expect(getCardValue("5♠")).toEqual(5); expect(getCardValue("10♥")).toEqual(10); // Note: We could also use a loop to check all values from 2 to 10. });

Why not make any change to your code accordingly.

cjyuan · 2025-07-17T21:51:05Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

+test("should return 10 for Jack of Clubs", () => {
+  const jackofClubs = getCardValue("J♣");
+  expect(jackofClubs).toEqual(10);
+});
+
+test("should return 10 for Queen of Hearts", () => {
+  const queenofHearts = getCardValue("Q♥");
+  expect(queenofHearts).toEqual(10);
+});
+
+test("should return 10 for King of Spades", () => {
+  const kingofSpades = getCardValue("K♠");
+  expect(kingofSpades).toEqual(10);
+});


We could combine these tests and place them under the category "should return 10 for face cards (J, Q, K)".

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js

cjyuan · 2025-07-17T21:58:49Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js

The tests in this Jest script are incomplete. When you have fully implemented the function in Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js, can you prepare tests in this script to cover all valid integers in the following way:

Group all possible input values into meaningful categories, and then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain.

For example, we can prepare a test for numbers 2, 22, 132, etc. as

test("append 'nd' to numbers ending in 2, except those ending in 12", () => { expect( getOrdinalNumber(2) ).toEqual("2nd"); expect( getOrdinalNumber(22) ).toEqual("22nd"); expect( getOrdinalNumber(132) ).toEqual("132nd"); });

cjyuan · 2025-07-17T22:01:27Z

Sprint-3/3-mandatory-practice/implement/repeat.js

Why not update the tests in Sprint-3/3-mandatory-practice/implement/repeat.test.js to check your implementation?

The test is updated, and all the tests have been passed.

I still could not see an updated Sprint-3/3-mandatory-practice/implement/repeat.test.js file. Did you forget to push your changes to GitHub?

My apologies, the tests are now updated.

…xpected error.

…ositive integer.

cjyuan

Files in "Sprint-1" folder not yet reverted.

cjyuan · 2025-07-20T22:34:55Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

+  if (rank === "A") return 11;
+  if (["K", "Q", "J"].includes(rank)) return 10;
+
+  const number = parseInt(rank);


parseInt() can return an integer but do you consider the values I suggested valid?

cjyuan · 2025-07-20T22:35:48Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

+test("should return 5 for 5 of Hearts", () => {
+  const fiveofHearts = getCardValue("5♥");
+  expect(fiveofHearts).toEqual(5);
+});
+
+test("should return 10 for 10 of Diamonds", () => {
+  const tenofDiamonds = getCardValue("10♦");
+  expect(tenofDiamonds).toEqual(10);
+});


Why not make any change to your code accordingly.

cjyuan · 2025-07-20T22:38:28Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js

Can you update the tests in this script so that they cover all valid integers?

cjyuan · 2025-07-20T22:39:35Z

Sprint-3/3-mandatory-practice/implement/repeat.js

I still could not see an updated Sprint-3/3-mandatory-practice/implement/repeat.test.js file. Did you forget to push your changes to GitHub?

cjyuan

Deleted files are still considered "changed files", and they will still show up in the "Files changed" tab, making code reviewing inconvenience. (In practice, it would also make merging difficult.)

One way to revert the changes is to do the following (to restore the files to their original version):

Download your main branch as a ZIP file.
In VSCode, switch to this branch (coursework/sprint-3).
Copy these two files from the ZIP file to this branch (make sure they are copied to the right folder).

Sprint-1/1-key-exercises/1-count.js
Sprint-1/readme.md

Verify and commit the change.
Push the change to Github.

cjyuan · 2025-07-21T21:31:41Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js

+//test("should return '1st' for 1", () => {
+//expect(getOrdinalNumber(1)).toEqual("1st");
+//});
+
+test("append 'st' to numbers ending in 1, except those ending in 11", () => {
+  expect(getOrdinalNumber(1)).toEqual("1st");
+  expect(getOrdinalNumber(21)).toEqual("21st");
+  expect(getOrdinalNumber(121)).toEqual("121st");
+});


Can you update the tests in this script so that they cover all valid integers?

cjyuan · 2025-07-21T21:36:41Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

+  if (rank === "A") return 11;
+  if (["K", "Q", "J"].includes(rank)) return 10;
+
+  const number = parseInt(rank);


The objective of the function is to determine the value of the rank of a card.

If you were to design a card game, would you allow the card to be displayed as
"2.9999999999999999999999♠", "3AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA♠"?

ahmadehsas added 15 commits June 16, 2025 17:22

Answered comment for count update in exercise -1

65fe894

Implement getAngleType with complete test coverage and improved test …

532fd66

…feedback

Completed the rest the tests and cases

0cba6bb

Implement getCardValue function with test cases for number, face, ace…

8d6eb95

…, and invalid cards

Implement getAngleType function to classify angle types

2479c4f

Add test cases for angle types and update Sprint-1 readme

3fafedf

Added function(isProperFraction)

7a5fe08

Identified Improper, Negative and equal fractions.

68f5551

Rewrote the Card value function and tests

5dd3b88

completed the countChar function with a short clear description and t…

62ef41d

…he goal of this function is to count how many times a specific character appears in a given string

completed the No occurrences Scenario test

1443cbf

completed the function getOrdinalNumber.

1e2318b

the test is passed for get-ordinal-number.js

edea881

Implemented the function and the test was passed

dbf4e92

Edited incorrect test cases and fixed logic to ensure all tests pass …

fad2100

…successfully.

ahmadehsas added the Needs Review Participant to add when requesting review label Jul 12, 2025

cjyuan added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 17, 2025

cjyuan reviewed Jul 17, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 17, 2025

ahmadehsas added 4 commits July 20, 2025 03:08

Add else condition to simplify my code.

1154f89

Add jest .toThrow method for checking if the function can throw the e…

047df5d

…xpected error.

implement the the function getOrdinalNumber that works for any vali p…

ba0f73e

…ositive integer.

prepare tests for all valid integers.

5aeb5c0

ahmadehsas added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jul 20, 2025

cjyuan reviewed Jul 20, 2025

View reviewed changes

cjyuan removed the Needs Review Participant to add when requesting review label Jul 20, 2025

cjyuan added the Reviewed Volunteer to add when completing a review label Jul 20, 2025

ahmadehsas added 6 commits July 21, 2025 14:40

combine tests for number cards and Face cards.

550f44d

update the function to hundle invalid input.

e76a59c

update the test code to hundle expected cases.

3415822

Match the error message in toThrow() matcher function.

bf5f7f8

Delete Sprint-1/1-key-exercises/1-count.js

4f1e86a

Delete Sprint-1/readme.md

e5699a5

ahmadehsas added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jul 21, 2025

cjyuan reviewed Jul 21, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 21, 2025

Uh oh!

WESTMIDLANDS | ITP-MAY-25 | AHMAD EHSAS | MODULE STRUCTURING AND TESTING DATA SPRINT-3 #656

Are you sure you want to change the base?

WESTMIDLANDS | ITP-MAY-25 | AHMAD EHSAS | MODULE STRUCTURING AND TESTING DATA SPRINT-3 #656

Uh oh!

Conversation

ahmadehsas commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Questions

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ahmadehsas commented Jul 12, 2025 •

edited

Loading