generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 195
London | May-2025 | Hendrine Zeraua | STD Sprint-2 #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rarityXtreme
wants to merge
15
commits into
CodeYourFuture:main
Choose a base branch
from
rarityXtreme:coursework/sprint-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
644c8fa
Fix function parameter redeclaration error
rarityXtreme 6ac4522
Fix syntax error caused by redeclaring function parameter as const
rarityXtreme 1cba6fa
Fix invalid function parameter and undefined variable in square function
rarityXtreme e08c6ac
Fix multiply function to return value instead of only logging it
rarityXtreme b07a431
Fix sum function to return value correctly and use return value in te…
rarityXtreme c352e10
Fix getLastDigit function to accept input parameter for flexibility
rarityXtreme 83f7e34
Implement calculateBMI function to return BMI rounded to 1 decimal place
rarityXtreme 5b6d12c
Add function to convert a sentence to UPPER_SNAKE_CASE
rarityXtreme e181dd2
Add reusable function to format pence strings into pound currency (e.…
rarityXtreme be3d00f
Add time formatting function with padding for hours, minutes, and sec…
rarityXtreme 6b637d0
Practiced using lastIndexOf and slice to split a file path into folde…
rarityXtreme 8a6e02b
Added explanation about function calls and clarified that percentage …
rarityXtreme 64e7f26
Complete and test formatAs12HourClock function with correct am/pm logic
rarityXtreme be11bbb
Fix: add missing closing brace to capitalise function
rarityXtreme dc23cbf
Revert unintended changes in Sprint-1 files
rarityXtreme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function block is not properly closed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi CJ,
I've added the missing curly braces for the function capitalise but for some reason I cannot spot the modified files in Sprint-1. Could you please direct me? I did check Sprint-1 - key-exercises - 3- paths.js and 3-mandatory-interpret - 1-percentage-change.js without success.
I appreciate your help reviewing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi CJ,
I've now reverted the changes made to the Sprint-1 files as requested. Let me know if there's anything else you'd like me to update. Thanks for reviewing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much. 🙏🏿