Glasgow | ITP May -25 | Pandi Simatupang | Module-Structuring-and-Testing-Data | coursework/sprint-3

Sprint-3/1-key-implement/1-get-angle-type.js

@@ -7,9 +7,28 @@
 // Write the code to pass the test
 // Then, write the next test! :) Go through this process until all the cases are implemented
 
+// function getAngleType(angle) {
+//   if (angle === 90) return "Right angle";
+//   else if (angle === 180) return "Straight angle";
+//   // read to the end, complete line 36, then pass your test here
+//   else if (angle < 90) return "Acute angle";
+//   else if (angle > 90 && angle < 180) return "Obtuse angle";
+//   else return "Reflex angle";
+// }
+
 function getAngleType(angle) {
-   if (angle === 90) return "Right angle";
-   // read to the end, complete line 36, then pass your test here
+  switch (true) {
+    case angle === 90:
+      return "Right angle";
+    case angle === 180:
+      return "Straight angle";
+    case angle < 90:
+      return "Acute angle";
+    case angle > 90 && angle < 180:
+      return "Obtuse angle";
+    default:
+      return "Reflex angle";
+  }
 }
 
 // we're going to use this helper function to make our assertions easier to read
@@ -42,15 +61,21 @@ assertEquals(acute, "Acute angle");
 // Case 3: Identify Obtuse Angles:
 // When the angle is greater than 90 degrees and less than 180 degrees,
 // Then the function should return "Obtuse angle"
+
 const obtuse = getAngleType(120);
 // ====> write your test here, and then add a line to pass the test in the function above
+assertEquals(obtuse, "Obtuse angle");
 
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
 // ====> write your test here, and then add a line to pass the test in the function above
+const straight = getAngleType(180);
+assertEquals(straight, "Straight angle");
 
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
-// ====> write your test here, and then add a line to pass the test in the function above
+// ====> write your test here, and then add a line to pass the test in the function above
+const reflex = getAngleType(190);
+assertEquals(reflex, "Reflex angle");

Sprint-3/1-key-implement/2-is-proper-fraction.js

@@ -7,8 +7,26 @@
 // complete the rest of the tests and cases
 // write one test at a time, and make it pass, build your solution up methodically
 
+// function isProperFraction(numerator, denominator) {
+//   if (numerator === 0 || denominator === 0) return false;
+//   else if (numerator === denominator) return false;
+//   else if (Math.abs(numerator) < Math.abs(denominator)) return true;
+//   else if (Math.abs(numerator) > Math.abs(denominator)) return false;
+// }
+
 function isProperFraction(numerator, denominator) {
-    if (numerator < denominator) return true;
+  switch (true) {
+    case numerator === 0 || denominator === 0:
+      return false;
+    case numerator === denominator:
+      return false;
+    case Math.abs(numerator) < Math.abs(denominator):
+      return true;
+    case Math.abs(numerator) > Math.abs(denominator):
+      return false;
+    default:
+      return false; // Just in case any weird input gets through
+  }
 }
 
 // here's our helper again
@@ -41,13 +59,24 @@ assertEquals(improperFraction, false);
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
 // ====> complete with your assertion
+assertEquals(negativeFraction, true);
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
 // ====> complete with your assertion
+assertEquals(equalFraction, false);
 
 // Stretch:
 // What other scenarios could you test for?
+
+const testFraction1 = isProperFraction(0, 0);
+assertEquals(testFraction1, false);
+
+const testFraction2 = isProperFraction(0, 3);
+assertEquals(testFraction2, false);
+
+const testFraction3 = isProperFraction(3, 0);
+assertEquals(testFraction3, false);

Sprint-3/1-key-implement/3-get-card-value.js

@@ -7,8 +7,56 @@
 // complete the rest of the tests and cases
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
+// function getCardValue(card) {
+//   let rank = card.slice(0, -1); //start from 0 until just before one last character
+//   if (rank === "A") return 11;
+//   else if ((rank === "10") | (rank === "J") | (rank === "Q") | (rank === "K"))
+//     return 10;
+//   else if (rank > 1 && rank < 10)
+//     return Number(
+//       rank
+//     ); //need to convert to number, because === compare type and exact number
+//   else return null;
+// }
+
+// function getCardValue(card) {
+//   const rank = card.slice(0, -1); // Get the rank part (e.g., "A", "10", "K")
+
+//   switch (rank) {
+//     case "A":
+//       return 11;
+//     case "10":
+//     case "J":
+//     case "Q":
+//     case "K":
+//       return 10;
+//     case "2":
+//     case "3":
+//     case "4":
+//     case "5":
+//     case "6":
+//     case "7":
+//     case "8":
+//     case "9":
+//       return Number(rank); // Convert to number from string
+//     default:
+//       return null; // Not a valid card
+//   }
+// }
+
 function getCardValue(card) {
-    if (rank === "A") return 11;
+  const rank = card.slice(0, -1);
+
+  switch (true) {
+    case rank === "A":
+      return 11;
+    case ["10", "J", "Q", "K"].includes(rank):
+      return 10;
+    case !isNaN(rank) && +rank >= 2 && +rank <= 9:
+      return Number(rank);
+    default:
+      return null;
+  }
 }
 
 // You need to write assertions for your function to check it works in different cases
@@ -22,7 +70,8 @@ function assertEquals(actualOutput, targetOutput) {
 }
 // Acceptance criteria:
 
-// Given a card string in the format "A♠" (representing a card in blackjack - the last character will always be an emoji for a suit, and all characters before will be a number 2-10, or one letter of J, Q, K, A),
+// Given a card string in the format "A♠" (representing a card in blackjack - the last character will always be an emoji for a suit,
+// and all characters before will be a number 2-10, or one letter of J, Q, K, A),
 // When the function getCardValue is called with this card string as input,
 // Then it should return the numerical card value
 const aceofSpades = getCardValue("A♠");
@@ -32,20 +81,27 @@ assertEquals(aceofSpades, 11);
 // Given a card with a rank between "2" and "9",
 // When the function is called with such a card,
 // Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
-const fiveofHearts = getCardValue("5♥");
+const fiveofHearts = getCardValue("8♥");
 // ====> write your test here, and then add a line to pass the test in the function above
+assertEquals(fiveofHearts, 8);
 
 // Handle Face Cards (J, Q, K):
 // Given a card with a rank of "10," "J," "Q," or "K",
 // When the function is called with such a card,
 // Then it should return the value 10, as these cards are worth 10 points each in blackjack.
+const alphabets = getCardValue("J♥");
+assertEquals(alphabets, 10);
 
 // Handle Ace (A):
 // Given a card with a rank of "A",
 // When the function is called with an Ace,
 // Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
+const rankA = getCardValue("A♥");
+assertEquals(rankA, 11);
 
 // Handle Invalid Cards:
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
+const inValidCard = getCardValue("14♥");
+assertEquals(inValidCard, null);

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

@@ -1,18 +1,15 @@
 function getAngleType(angle) {
   if (angle === 90) return "Right angle";
   // replace with your completed function from key-implement
-
+  else if (angle === 180) return "Straight angle";
+  // read to the end, complete line 36, then pass your test here
+  else if (angle < 90) return "Acute angle";
+  else if (angle > 90 && angle < 180) return "Obtuse angle";
+  else return "Reflex angle";
 }
 
-
-
-
-
-
-
-
 // Don't get bogged down in this detail
 // Jest uses CommonJS module syntax by default as it's quite old
-// We will upgrade our approach to ES6 modules in the next course module, so for now 
+// We will upgrade our approach to ES6 modules in the next course module, so for now
 // we have just written the CommonJS module.exports syntax for you
-module.exports = getAngleType;
+module.exports = getAngleType;

Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js

@@ -1,24 +1,23 @@
 const getAngleType = require("./1-get-angle-type");
 
-test("should identify right angle (90°)", () => {
+test("testing for multiple different angles", () => {
+  // REPLACE the comments with the tests
+  // make your test descriptions as clear and readable as possible
+
+  // Case 2: Identify Acute Angles:
+  // When the angle is less than 90 degrees,
+  // Then the function should return "Acute angle"
   expect(getAngleType(90)).toEqual("Right angle");
+  // Case 3: Identify Obtuse Angles:
+  // When the angle is greater than 90 degrees and less than 180 degrees,
+  // Then the function should return "Obtuse angle"
+  expect(getAngleType(120)).toEqual("Obtuse angle");
+  // Case 4: Identify Straight Angles:
+  // When the angle is exactly 180 degrees,
+  // Then the function should return "Straight angle"
+  expect(getAngleType(180)).toEqual("Straight angle");
+  // Case 5: Identify Reflex Angles:
+  // When the angle is greater than 180 degrees and less than 360 degrees,
+  // Then the function should return "Reflex angle"
+  expect(getAngleType(300)).toEqual("Reflex angle");
 });
-
-// REPLACE the comments with the tests
-// make your test descriptions as clear and readable as possible
-
-// Case 2: Identify Acute Angles:
-// When the angle is less than 90 degrees,
-// Then the function should return "Acute angle"
-
-// Case 3: Identify Obtuse Angles:
-// When the angle is greater than 90 degrees and less than 180 degrees,
-// Then the function should return "Obtuse angle"
-
-// Case 4: Identify Straight Angles:
-// When the angle is exactly 180 degrees,
-// Then the function should return "Straight angle"
-
-// Case 5: Identify Reflex Angles:
-// When the angle is greater than 180 degrees and less than 360 degrees,
-// Then the function should return "Reflex angle"

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

@@ -1,6 +1,11 @@
 function isProperFraction(numerator, denominator) {
-    if (numerator < denominator) return true;
-    // add your completed function from key-implement here
+  //if (numerator < denominator) return true;
+  // add your completed function from key-implement here
+
+  if (numerator === 0 || denominator === 0) return false;
+  if (numerator === denominator) return false;
+  if (Math.abs(numerator) < Math.abs(denominator)) return true;
+  if (Math.abs(numerator) > Math.abs(denominator)) return false;
 }
 
-module.exports = isProperFraction;
+module.exports = isProperFraction;

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js

@@ -5,7 +5,16 @@ test("should return true for a proper fraction", () => {
 });
 
 // Case 2: Identify Improper Fractions:
+test("should return true for a proper fraction", () => {
+  expect(isProperFraction(0, 0)).toEqual(false);
+});
 
 // Case 3: Identify Negative Fractions:
+test("should return true for a proper fraction", () => {
+  expect(isProperFraction(-1, 4)).toEqual(true);
+});
 
 // Case 4: Identify Equal Numerator and Denominator:
+test("should return true for a proper fraction", () => {
+  expect(isProperFraction(5, 5)).toEqual(false);
+});

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

@@ -1,5 +1,12 @@
 function getCardValue(card) {
-    // replace with your code from key-implement
-    return 11;
+  // replace with your code from key-implement
+  //return 11;
+  let rank = card.slice(0, -1); //start from 0 until just before one last character
+  if (rank === "A") return 11;
+  else if ((rank === "10") | (rank === "J") | (rank === "Q") | (rank === "K"))
+    return 10;
+  else if (rank > 1 && rank < 10) return Number(rank);
+  //need to convert to number, because === compare type and exact number
+  else return null;
 }
-module.exports = getCardValue;
+module.exports = getCardValue;

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

@@ -1,11 +1,29 @@
 const getCardValue = require("./3-get-card-value");
 
 test("should return 11 for Ace of Spades", () => {
-    const aceofSpades = getCardValue("A♠");
-    expect(aceofSpades).toEqual(11);
-    });
+  const aceofSpades = getCardValue("A♠");
+  expect(aceofSpades).toEqual(11);
+});
 
 // Case 2: Handle Number Cards (2-10):
+test("should return 5 for Ace of Spades", () => {
+  const fiveSpades = getCardValue("5♠");
+  expect(fiveSpades).toEqual(5);
+});
+
 // Case 3: Handle Face Cards (J, Q, K):
+test("should return 10 for K of Spades", () => {
+  const KSpades = getCardValue("K♠");
+  expect(KSpades).toEqual(10);
+});
+
 // Case 4: Handle Ace (A):
+test("should return 11 for A of Spades", () => {
+  const ASpades = getCardValue("A♠");
+  expect(ASpades).toEqual(11);
+});
 // Case 5: Handle Invalid Cards:
+test("should return null for 17 of Spades", () => {
+  const invalidCard = getCardValue("17♠");
+  expect(invalidCard).toEqual(null);
+});

Sprint-3/3-mandatory-practice/implement/count.js

@@ -1,5 +1,12 @@
 function countChar(stringOfCharacters, findCharacter) {
-    return 5
+  let numberOfFindChar = 0;
+  let lengthOfString = stringOfCharacters.length;
+  for (let i = 0; i < lengthOfString; i++) {
+    if (findCharacter === stringOfCharacters[i]) numberOfFindChar++;
+  }
+  return numberOfFindChar;
 }
 
-module.exports = countChar;
+//console.log(countChar("aaaaaaaaaaaaaaaaaaaaabaaaa", "b"));
+
+module.exports = countChar;

Sprint-3/3-mandatory-practice/implement/count.test.js

@@ -11,9 +11,9 @@ const countChar = require("./count");
 // Then it should correctly count overlapping occurrences of char (e.g., 'a' appears five times in 'aaaaa').
 
 test("should count multiple occurrences of a character", () => {
-  const str = "aaaaa";
-  const char = "a";
-  const count = countChar(str, char);
+  const myStr = "aaaaa";
+  const myChar = "a";
+  const count = countChar(myStr, myChar);
   expect(count).toEqual(5);
 });
 
@@ -22,3 +22,9 @@ test("should count multiple occurrences of a character", () => {
 // And a character char that does not exist within the case-sensitive str,
 // When the function is called with these inputs,
 // Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str.
+test("should count multiple occurrences of a character", () => {
+  const myStr = "b";
+  const myChar = "a";
+  const count = countChar(myStr, myChar);
+  expect(count).toEqual(0);
+});