London | ITP-May-2025 | Surafel Workneh | Structuring and testing data | Coursework/sprint 1 #646
Conversation
…gnment sprint -1 of 1-count.js
…m number generation in sprint -1 of 4-random.js
…'let' in sprint -1 of 1.js
…licing in sprint -1 of 3.js
…ons in sprint -1 of 4.js
…reassignment in percentage change calculation
…sprint -1 of 2-time-format.js
and describe the purpose in sprint -1 of 3-to-pounds.js
… sprint -1 of chrome.md
SuWebOnes
changed the title
SuWebOnes
changed the title
SuWebOnes
changed the title
cjyuan
added
Review in progress
| // 1. const penceString = "399p": initialize a string variable with the value "399p" | ||
| //2. Removes the trailing "p" from the string: and result will be 399 | ||
| //3. Ensures the number has at least 3 digits by padding from the left with zeros: like 000 | ||
| //4. Extracts the pound portion: "3" |
There was a problem hiding this comment.
Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") (line 16) from the code?
In other words, do we really need .padEnd(2, "0") in this script?
There was a problem hiding this comment.
yes, it can work without '.padEnd(2, "0") (line 16) from the code? ' and I tested with different digits and it works
There was a problem hiding this comment.
You don't have to delete .padEnd(2, "0"). It's a "code reading" practice.
More importantly, do you know why the script can still works correctly without .padEnd(2, "0")?
There was a problem hiding this comment.
Do you know why the script can still works correctly without .padEnd(2, "0")?
cjyuan
added
Reviewed
|
CJ would you mind if you check revisions please? |
| What is the return value of `prompt`? | ||
| Shows input dialog |
There was a problem hiding this comment.
What is the value returned by prompt()?
The function returns different values depending on whether the user clicks the OK button or the Cancel button.
| // 1. const penceString = "399p": initialize a string variable with the value "399p" | ||
| //2. Removes the trailing "p" from the string: and result will be 399 | ||
| //3. Ensures the number has at least 3 digits by padding from the left with zeros: like 000 | ||
| //4. Extracts the pound portion: "3" |
There was a problem hiding this comment.
Do you know why the script can still works correctly without .padEnd(2, "0")?
SuWebOnes
added
🏕 Priority Mandatory
Learners, PR Template
Self checklist
Changelist
Briefly explain my PR.
Function Parameter and Return Handling
String Manipulation and Formatting
Time Conversion Logic
Testing and Debugging
Questions
Ask any questions you have for your reviewer.