-
-
Notifications
You must be signed in to change notification settings - Fork 195
Glasgow | May-2025 | Salah Ahmed| Sprint-3 #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…and error handling
…lue for unknown angles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there might be a bit of confusion regarding the package.json and package-lock.json files.
When I asked you to remove them from the PR, it seems you may have thought I asked you to "remove" the file from the project completely.
The file needs to remain in the project (on GitHub) but shouldn't be in your PR.
If you included the file as a deletion in your PR, it could cause issues.
You can use chatGPT to see how you can remove this file from the PR. If you find you are stuck, let me know and I can give you more instructions on how to revert these changes!
The package-lock.json file shouldn't be included in the PR either.

I usually stage and commit my changes in GitHub. I didn’t include these
files. This sprint has been really difficult—there were a lot of issues
with the files, changes, and problems in VS Code. The next two sprints in
The Data grousp module are already completed, but I’m stuck on this one
because of all the errors and technical issues in the editor.
…On Sat, Jul 19, 2025 at 2:22 AM Jennifer Alexander ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I think there might be a bit of confusion regarding the package.json and
package-lock.json files.
When I asked you to remove them from the PR, it seems you may have thought
I asked you to "remove" the file from the project completely.
The file needs to *remain* in the project (on GitHub) but shouldn't be in
your PR.
If you included the file as a deletion in your PR, it could cause issues.
You can use chatGPT to see how you can remove this file from the PR. If
you find you are stuck, let me know and I can give you more instructions on
how to revert these changes!
The package-lock.json file shouldn't be included in the PR either.
Screenshot.2025-07-18.at.8.10.01.PM.png (view on web)
<https://github.com/user-attachments/assets/42e8b1f2-b5fe-40ce-b269-9d90a055f370>
—
Reply to this email directly, view it on GitHub
<#634 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANX5L23JS5A53EU24P6ILT3JGMWLAVCNFSM6AAAAACAVLW24CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMZVGA2DMMJTG4>
.
You are receiving this because you were mentioned.Message ID:
<CodeYourFuture/Module-Structuring-and-Testing-Data/pull/634/review/3035046137
@github.com>
--
SALAH AHMED <https://www.freelancer.com/affiliates/email/1071775/>
Founder and CEO, specializing in E-work and business development consulting
M: +970599884399
E: ***@***.***
A: 6th FL., Alroaya Tower, Thalatheni St.
|
@avatarit - I think there are many CYF trainees who have found this sprint challenging. A lot is being asked of you with these exercises and because the learning curve with these concepts is high -> it can feel frustrating. There are 4 files that shouldn't be in your PR:
The main branch version of these files can be found here: https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data You can make these changes either using git command line or using the GitHub interface: ➡️ Here is what chatGPT says on how to do that using the GitHub interface: ➡️ Here is what chatGPT says on how to modify the files using the git command line: If you aren't already, I strongly recommend that at some point in your training you start to use the git command line as it is very powerful and gives you better control over git (compared with GitHub UI). 😄 Message back here if you need more help with it! |
Hi Jenny,
Unfortunately, I failed to remove it. I have tried all the solutions and I
cannot remove it.
Thanks
[image: image.png]
…On Sat, Jul 19, 2025 at 5:49 PM Jennifer Alexander ***@***.***> wrote:
*jenny-alexander* left a comment
(CodeYourFuture/Module-Structuring-and-Testing-Data#634)
<#634 (comment)>
@avatarit <https://github.com/avatarit> - I think there are many CYF
trainees who have found this sprint challenging. A lot is being asked of
you with these exercises and because the learning curve with these concepts
is high -> it can feel frustrating.
But don't forget, for each frustration you overcome, you learned something
new and the next time, it won't be so hard!
------------------------------
There are 4 files that shouldn't be in your PR:
1. .vscode/extensions.json: This file was *modified* so you should
revert to the version of this file on the main branch.
2. .gitignore: This file was *modified* so you should revert to the
version of this file on the main branch.
3. package-lock.json: This file was *added*, so you can delete it from
the PR.
4. package.json: This file was *modified* so you should revert to the
version of this file on the main branch.
The main branch version of these files can be found here:
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data
You can make these changes either using git command line or using the
GitHub interface:
➡️ Here is what chatGPT says on how to do that using the GitHub interface:
Screenshot.2025-07-19.at.11.40.43.AM.png (view on web)
<https://github.com/user-attachments/assets/5190de31-461f-4374-a3be-8bf0ec2d872d>
➡️ Here is what chatGPT says on how to modify the files using the git
command line:
Screenshot.2025-07-19.at.11.38.21.AM.png (view on web)
<https://github.com/user-attachments/assets/374a91d7-e60c-4fae-abc3-64117a0dca1e>
If you aren't already, I strongly recommend that at some point in your
training you start to use the git command line as it is very powerful and
gives you better control over git (compared with GitHub UI). 😄
Message back here if you need more help with it!
—
Reply to this email directly, view it on GitHub
<#634 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANX5L5VKVACTPQCAUOPZML3JJZH5AVCNFSM6AAAAACAVLW24CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJSGQ2DSOBXGI>
.
You are receiving this because you were mentioned.Message ID:
<CodeYourFuture/Module-Structuring-and-Testing-Data/pull/634/c3092449872@
github.com>
--
SALAH AHMED <https://www.freelancer.com/affiliates/email/1071775/>
Founder and CEO, specializing in E-work and business development consulting
M: +970599884399
E: ***@***.***
A: 6th FL., Alroaya Tower, Thalatheni St.
|
No problem!
|
Can we make a zoom call and share my screen ?
…On Sat, Jul 19, 2025 at 7:20 PM Jennifer Alexander ***@***.***> wrote:
*jenny-alexander* left a comment
(CodeYourFuture/Module-Structuring-and-Testing-Data#634)
<#634 (comment)>
No problem!
- Can you post what steps you followed?
- Can you post a screenshot of how it is failing to be removed?
- Did you try with the git commands via terminal within VSCode? ❓
Would you like to me take a video of doing it via git command line?
—
Reply to this email directly, view it on GitHub
<#634 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANX5L7F5VHGAT2MFSURRID3JKD6PAVCNFSM6AAAAACAVLW24CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJSGQ4TOMJUHA>
.
You are receiving this because you were mentioned.Message ID:
<CodeYourFuture/Module-Structuring-and-Testing-Data/pull/634/c3092497148@
github.com>
--
SALAH AHMED <https://www.freelancer.com/affiliates/email/1071775/>
Founder and CEO, specializing in E-work and business development consulting
M: +970599884399
E: ***@***.***
A: 6th FL., Alroaya Tower, Thalatheni St.
|
It's just after midnight for me here in central USA. I don't know how easy it will be tomorrow with the time difference. I'll ask another volunteer that is in your timezone to help with this last step. Is that okay with you? |
Hi Jenny,
Yes, that’s totally okay with me—thanks for checking! I really appreciate
you coordinating this, especially at such a late hour. Let me know if
there’s anything else you need from my side.
During Saturday’s session, two volunteers tried to assist, but
unfortunately, all our attempts didn’t work out. We even thought about
creating a new PR. I suspect there’s a bigger technical issue on my end—my
VS Code kept crashing throughout this sprint.
Thank for help
…On Sun, Jul 20, 2025 at 6:08 AM Jennifer Alexander ***@***.***> wrote:
*jenny-alexander* left a comment
(CodeYourFuture/Module-Structuring-and-Testing-Data#634)
<#634 (comment)>
It's just after midnight for me here in central USA. I don't know how easy
it will be tomorrow with the time difference. I'll ask another volunteer
that is in your timezone to help with this last step. Is that okay with you?
—
Reply to this email directly, view it on GitHub
<#634 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANX5LY33MT7HRDWLZ2AZJL3JMP6XAVCNFSM6AAAAACAVLW24CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJTGIYDQOJSGI>
.
You are receiving this because you were mentioned.Message ID:
<CodeYourFuture/Module-Structuring-and-Testing-Data/pull/634/c3093208922@
github.com>
--
SALAH AHMED <https://www.freelancer.com/affiliates/email/1071775/>
Founder and CEO, specializing in E-work and business development consulting
M: +970599884399
E: ***@***.***
A: 6th FL., Alroaya Tower, Thalatheni St.
|
I requested for help from the review team regarding your PR. Let's see what they say! |
Okay thank
…On Sun, Jul 20, 2025 at 6:12 PM Jennifer Alexander ***@***.***> wrote:
*jenny-alexander* left a comment
(CodeYourFuture/Module-Structuring-and-Testing-Data#634)
<#634 (comment)>
I requested for help from the review team regarding your PR. Let's see
what they say!
—
Reply to this email directly, view it on GitHub
<#634 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANX5L5WVMT4U6WNGI4AON33JPEZBAVCNFSM6AAAAACAVLW24CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJUGY2TMMBYGA>
.
You are receiving this because you were mentioned.Message ID:
<CodeYourFuture/Module-Structuring-and-Testing-Data/pull/634/c3094656080@
github.com>
--
SALAH AHMED <https://www.freelancer.com/affiliates/email/1071775/>
Founder and CEO, specializing in E-work and business development consulting
M: +970599884399
E: ***@***.***
A: 6th FL., Alroaya Tower, Thalatheni St.
|
@avatarit These are the four "changed files" you need to revert if you were to make the branch cleaner. Here is one possible way you can revert the changes:
|
Eliminates a redundant trailing newline in the VS Code extensions configuration file to maintain consistent formatting.
Hi everyone,
I have created a new branch coursework/sprint3 as shown in the attached
image. The new branch does not include any json files.
Unfortunately, when I tried to make the new PR. I noticed that these files
are included as shown in the attached image.
I am now sure how to solve this problem.
I feel frustrated and stuck in this sprint for 3 weeks.
Regards
…On Sun, Jul 20, 2025 at 8:08 PM CJ Yuan ***@***.***> wrote:
*cjyuan* left a comment
(CodeYourFuture/Module-Structuring-and-Testing-Data#634)
<#634 (comment)>
@avatarit <https://github.com/avatarit> These are the four "changed
files" you need to revert if you were to make the branch cleaner.
image.png (view on web)
<https://github.com/user-attachments/assets/8ddfe788-fbb8-4119-8d13-1e593adfe1c7>
Here is one possible way you can revert the changes:
1.
Download your main branch from GitHub as a ZIP file:
https://github.com/avatarit/Module-Structuring-and-Testing-Data/tree/main
2.
Open your repository in VSCode and switch to branch
"coursework/sprint-3" (this branch).
3.
Delete package-lock.json.
4.
Replace the following three files in this branch by the version of
these files in the downloaded ZIP file.
- .gitignore
- .vscode/extensions.json
- package.json
5. Commit the change and push the change to GitHub.
—
Reply to this email directly, view it on GitHub
<#634 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANX5L5MKJW4LEYJ337ATA33JPSKHAVCNFSM6AAAAACAVLW24CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJUG4YTGMBXGM>
.
You are receiving this because you were mentioned.Message ID:
<CodeYourFuture/Module-Structuring-and-Testing-Data/pull/634/c3094713073@
github.com>
--
SALAH AHMED <https://www.freelancer.com/affiliates/email/1071775/>
Founder and CEO, specializing in E-work and business development consulting
M: +970599884399
E: ***@***.***
A: 6th FL., Alroaya Tower, Thalatheni St.
|
Thanks for your help.
The issue has been resolved.
Regards
…On Sun, Jul 20, 2025 at 8:08 PM CJ Yuan ***@***.***> wrote:
*cjyuan* left a comment
(CodeYourFuture/Module-Structuring-and-Testing-Data#634)
<#634 (comment)>
@avatarit <https://github.com/avatarit> These are the four "changed
files" you need to revert if you were to make the branch cleaner.
image.png (view on web)
<https://github.com/user-attachments/assets/8ddfe788-fbb8-4119-8d13-1e593adfe1c7>
Here is one possible way you can revert the changes:
1.
Download your main branch from GitHub as a ZIP file:
https://github.com/avatarit/Module-Structuring-and-Testing-Data/tree/main
2.
Open your repository in VSCode and switch to branch
"coursework/sprint-3" (this branch).
3.
Delete package-lock.json.
4.
Replace the following three files in this branch by the version of
these files in the downloaded ZIP file.
- .gitignore
- .vscode/extensions.json
- package.json
5. Commit the change and push the change to GitHub.
—
Reply to this email directly, view it on GitHub
<#634 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANX5L5MKJW4LEYJ337ATA33JPSKHAVCNFSM6AAAAACAVLW24CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJUG4YTGMBXGM>
.
You are receiving this because you were mentioned.Message ID:
<CodeYourFuture/Module-Structuring-and-Testing-Data/pull/634/c3094713073@
github.com>
--
SALAH AHMED <https://www.freelancer.com/affiliates/email/1071775/>
Founder and CEO, specializing in E-work and business development consulting
M: +970599884399
E: ***@***.***
A: 6th FL., Alroaya Tower, Thalatheni St.
|
Complete! 🥳 |
Thanks a lot for your support 🥳
…On Tue, Jul 22, 2025 at 7:30 PM Jennifer Alexander ***@***.***> wrote:
*jenny-alexander* left a comment
(CodeYourFuture/Module-Structuring-and-Testing-Data#634)
<#634 (comment)>
Complete! 🥳
—
Reply to this email directly, view it on GitHub
<#634 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANX5L2RXM3IYQXXR4ZWOQ33JZ7LPAVCNFSM6AAAAACAVLW24CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMBUGI3DGOJQGU>
.
You are receiving this because you were mentioned.Message ID:
<CodeYourFuture/Module-Structuring-and-Testing-Data/pull/634/c3104263905@
github.com>
--
SALAH AHMED <https://www.freelancer.com/affiliates/email/1071775/>
Founder and CEO, specializing in E-work and business development consulting
M: +970599884399
E: ***@***.***
A: 6th FL., Alroaya Tower, Thalatheni St.
|
Self checklist
Changelist
All the issues have been solved in Sprint 3