LONDON | MAY2025 | JESUS DEL MORAL | STRUCTURING AND TESTING DATA SPRINT 3 #581

delmorallopez · 2025-06-20T16:42:40Z

LONDON | MAY2025 | JESUS DEL MORAL | STRUCTURING AND TESTING DATA SPRINT 3

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

jenny-alexander

Your PR is on the right track. There are a few functional requirements we still need to address - I've left comments in your PR to help you about these. 🙂

There are 3 files that shouldn't be included in this PR since they aren't modified for this exercise:
- pull_request_template.md
- package-lock.json
- package.json

I don't see the tests for Sprint-3/3-mandatory-practice. Is it possible that you forgot these?

Sprint-3/1-key-implement/1-get-angle-type.js

jenny-alexander · 2025-07-13T21:50:45Z

Sprint-3/1-key-implement/1-get-angle-type.js

 const right = getAngleType(90);
+console.log(right);


💭 It's a good idea to remove these console logs before submitting your PR since they are not required for the exercise.

I have removed all the console logs

Sprint-3/1-key-implement/1-get-angle-type.js

jenny-alexander · 2025-07-13T21:53:55Z

Sprint-3/1-key-implement/2-is-proper-fraction.js

@@ -27,27 +30,37 @@ function assertEquals(actualOutput, targetOutput) {
 // Explanation: The fraction 2/3 is a proper fraction, where the numerator is less than the denominator. The function should return true.
 const properFraction = isProperFraction(2, 3);
 assertEquals(properFraction, true);
+console.log(properFraction)


You may have forgotten to remove these console logs before submitting your PR. Can you remove them?

All the console logs has been removed

jenny-alexander · 2025-07-13T21:55:32Z

Sprint-3/1-key-implement/2-is-proper-fraction.js

-    if (numerator < denominator) return true;
-}
-
+    if (numerator < denominator) {


🌱 Consider this: you can return a boolean value of true or false by doing a simple check of the values themselves.
i.e.
return numerator < denominator;
This will return true if numerator is less than denominator. It will return false if numerator greater than or equal to the denominator

You can add a check for zero before any other checks. If the denominator is zero, you can return false.

I have simplified the function

function isProperFraction(numerator, denominator) {
if (denominator == 0){
return false
}
return numerator < denominator;
}

Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

jenny-alexander · 2025-07-13T22:20:04Z

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js

 // Case 4: Identify Equal Numerator and Denominator:
+
+
+test("should return True for a proper fraction", () => {


Can you review the test assertion text here? You are saying you expect this proper fraction to return true but you are checking for 'false'

I modified the test and the function

test("should return True for a proper fraction", () => {
expect(isProperFraction(3, 3)).toEqual(true);
});

Can you check the instruction explanations for a proper fraction again. I see this:
Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.

Your test is not validating the correct thing since 3/3 should return an improper fraction.

The test has been modified

test("should return False for a proper fraction", () => {
expect(isProperFraction(3, 3)).toEqual(false);
});

jenny-alexander · 2025-07-13T22:30:28Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

+    const invalid = getCardValue("-1");
+    expect(invalid).toEqual('Invalid card rank.');
+    });
+


I didn't get the expected value when I tested these scenarios:

test("should return the value 10 for 10 of hearts ", () => { const tenOfHearts = getCardValue("10♥"); expect(tenOfHearts).toEqual(10); }); test("should return the value Invalid card rank for value of 22", () => { const twentyTwo = getCardValue("22"); expect(twentyTwo).toEqual("Invalid card rank."); });

Can you investigate and see if you can find the issue?

I have included these two scenarios and tested them. All of them working fine

@delmorallopez - can you review your function again? The change you made (returning the value of the test within the function is not the right approach here.

Here are some tips to help you out:

Get the suit: the last character of the string will be the suit (♥, ♠, etc).

Get the rank: the part of the string before the suit is going to be either a number or 'A', 'J', 'Q', or 'K'.

if the rank is 'A', the value is always 11.

if the rank is any of these: 'J', 'Q', or 'K', the value of the card is 10.

if the rank value is 2,3,4,5,6,7,8,9,10 -> then the card value is the rank.

anything else is an 'invalid card value'.

I modified the getCardValue function considering all the scenarios
All the tests have been passed

function getCardValue(card) {
if (typeof card !== 'string' || card.length < 2) {
return 'Invalid card rank.';
}

const validSuits = ['♠', '♥', '♦', '♣'];
const suit = card.slice(-1); // Last character
const rank = card.slice(0, -1); // Everything before last character

if (!validSuits.includes(suit)) {
return 'Invalid card rank.';
}

if (rank === 'A') {
return 11;
} else if (['J', 'Q', 'K'].includes(rank)) {
return 10;
} else if (!isNaN(rank)) {
const numericRank = Number(rank);
if (numericRank >= 2 && numericRank <= 10) {
return numericRank;
}
}

return 'Invalid card rank.';
}

jenny-alexander

@delmorallopez - Can you please review all of the comments in the PR? There were quite a few that were not addressed.
If you're struggling with a specific part of this exercise, don't forget that there is a community of people on Slack who can help. 😃
A good tip is to give yourself about 1 hour and then reach out for help! You want to give yourself enough time to see if you can find the solution - but you don't want to get frustrated by getting stuck on a problem for too long.

jenny-alexander · 2025-07-13T22:39:30Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

-    return 11;
-}
+    let rank = card.charAt(0);
+    console.log(rank);


This console.log should be removed from the PR. Console logs can:

impact performance

clutter the browser console

look unprofessional

Console log is still in the code.

@jenny-alexander
The console logs has been removed

Sprint-3/1-key-implement/1-get-angle-type.js

Sprint-3/1-key-implement/2-is-proper-fraction.js

jenny-alexander · 2025-07-15T22:09:39Z

Sprint-3/1-key-implement/3-get-card-value.js

@@ -8,7 +8,22 @@
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {


Can you review the above☝️failing tests and implement something within your function to ensure that they don't fail!

jenny-alexander · 2025-07-15T22:10:28Z

Sprint-3/1-key-implement/3-get-card-value.js

@@ -8,7 +8,22 @@
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
-    if (rank === "A") return 11;
+  let rank = card.charAt(0);
+  console.log(rank);


@delmorallopez - console log (line 12) is still in your function. Please review.

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

jenny-alexander · 2025-07-15T22:16:11Z

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js

 // Case 4: Identify Equal Numerator and Denominator:
+
+
+test("should return True for a proper fraction", () => {


Can you check the instruction explanations for a proper fraction again. I see this:
Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.

Your test is not validating the correct thing since 3/3 should return an improper fraction.

jenny-alexander · 2025-07-15T22:30:24Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

+    const invalid = getCardValue("-1");
+    expect(invalid).toEqual('Invalid card rank.');
+    });
+


@delmorallopez - can you review your function again? The change you made (returning the value of the test within the function is not the right approach here.

Here are some tips to help you out:

Get the suit: the last character of the string will be the suit (♥, ♠, etc).

Get the rank: the part of the string before the suit is going to be either a number or 'A', 'J', 'Q', or 'K'.

if the rank is 'A', the value is always 11.

if the rank is any of these: 'J', 'Q', or 'K', the value of the card is 10.

if the rank value is 2,3,4,5,6,7,8,9,10 -> then the card value is the rank.

anything else is an 'invalid card value'.

Sprint-3/1-key-implement/1-get-angle-type.js

delmorallopez · 2025-07-18T13:30:34Z

@jenny-alexander

I have added the test for Wrong Angle

// Case 6: Identify Wrong Angles:
// When the angle is different to the all scenarios above,

const wrong = getAngleType(400);
assertEquals(wrong, "Wrong angle");

jenny-alexander

Please review this requested change:
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/pull/581/files#r2216678978

Sprint-3/1-key-implement/2-is-proper-fraction.js

delmorallopez · 2025-07-19T10:20:03Z

@jenny-alexander
The function is now using the absolute value of Numerator and denominator

return Math.abs(numerator) < Math.abs(denominator);

All test passed

delmorallopez added 2 commits June 16, 2025 14:21

Sprint-3/Key-implement

4575e7b

Sprint-3/mandatory-rewrited

91085e5

delmorallopez added the Needs Review Participant to add when requesting review label Jun 20, 2025

delmorallopez changed the title ~~Coursework/sprint 3~~ LONDON | MAY2025 | JESUS DEL MORAL | STRUCTURING AND TESTING DATA SPRINT 3 Jun 20, 2025

delmorallopez force-pushed the coursework/sprint-3 branch from a2a857e to 91085e5 Compare June 20, 2025 18:13

jenny-alexander self-requested a review July 13, 2025 04:41

jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 13, 2025

jenny-alexander suggested changes Jul 13, 2025

View reviewed changes

jenny-alexander added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 13, 2025

Sprint3 review

5797ab8

delmorallopez added the Needs Review Participant to add when requesting review label Jul 15, 2025

jenny-alexander suggested changes Jul 15, 2025

View reviewed changes

jenny-alexander removed the Needs Review Participant to add when requesting review label Jul 15, 2025

Sprint3-review

bf2b29f

delmorallopez added the Needs Review Participant to add when requesting review label Jul 16, 2025

jenny-alexander suggested changes Jul 17, 2025

View reviewed changes

Sprint-3/1-key-implement/1-get-angle-type.js Show resolved Hide resolved

Spring3-Review

a89ab50

delmorallopez added Needs Review Participant to add when requesting review and removed Needs Review Participant to add when requesting review labels Jul 18, 2025

jenny-alexander suggested changes Jul 18, 2025

View reviewed changes

Sprint-3/1-key-implement/2-is-proper-fraction.js Show resolved Hide resolved

Sprint3-Review

aaca635

illicitonion changed the base branch from to-be-deleted-coursework/sprint-3 to main July 21, 2025 09:45

		// Case 4: Identify Equal Numerator and Denominator:


		test("should return True for a proper fraction", () => {

Uh oh!

LONDON | MAY2025 | JESUS DEL MORAL | STRUCTURING AND TESTING DATA SPRINT 3 #581

Are you sure you want to change the base?

LONDON | MAY2025 | JESUS DEL MORAL | STRUCTURING AND TESTING DATA SPRINT 3 #581

Uh oh!

Conversation

delmorallopez commented Jun 20, 2025

Uh oh!

jenny-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jenny-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

delmorallopez commented Jul 18, 2025

Uh oh!

jenny-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

delmorallopez commented Jul 19, 2025

Uh oh!

Uh oh!

jenny-alexander Jul 15, 2025 •

edited

Loading

jenny-alexander Jul 15, 2025 •

edited

Loading