Skip to content

Manchester | 25-ITP-September | Fatimatou Bah | Sprint 1 | Wireframe #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Manchester | 25-ITP-September | Fatimatou Bah | Sprint 1 | Wireframe #905

wants to merge 12 commits into from

Conversation

@Faatima-Bah
Copy link

@Faatima-Bah Faatima-Bah commented Oct 10, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have made changes to create a functional wireframe website, I have

  • Used Semantic HTML: header, three articles, each including a title, summary and link, and fixed footer
  • Scored 100% on Accessibility on Lighthouse
  • Check a webpage against a wireframe layout
  • Used version control by committing often and pushing regularly to GitHub
  • Made sure the webpage is styled using a linked .css file.

@netlify
Copy link

netlify bot commented Oct 10, 2025 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit dbd499b
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68e9558fd15e4e00081b7aa4
😎 Deploy Preview https://deploy-preview-905--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 95 (🟢 up 9 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Your PR's title didn't contain a known region.

Please check the expected title format, and make sure your region is in the correct place and spelled correctly.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan
cjyuan reviewed Oct 10, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

  • W3C Validator gives some warnings to your HTML code. Can you address them?

Regarding the PR

  • Why didn't you add "Needs review" label to your PR?
  • In your PR description, if you don't have any question to ask, you can either delete the Questions section or replace the placeholder text in order to pass the automated validate_pr_metadata checks.
  • Your PR title does not quite match the format suggested in the PR template.

You can find the info about preparing PR in this PR Guide.

@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Oct 10, 2025
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Your PR's title didn't contain a known region.

Please check the expected title format, and make sure your region is in the correct place and spelled correctly.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Faatima-Bah Faatima-Bah changed the title Northwest | September-2025 | Fatimatou Bah | Onboarding | Wireframe to Web Code Manchester | 25-ITP-September | Fatimatou Bah | Sprint 1 | Wireframe Oct 10, 2025
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Faatima-Bah Faatima-Bah added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 10, 2025
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@cjyuan
Copy link
Contributor

cjyuan commented Oct 10, 2025

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 10, 2025
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Faatima-Bah Faatima-Bah mentioned this pull request Oct 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Faatima-Bah @cjyuan