Skip to content

Conversation

@adamazakaria2021
Copy link

@adamazakaria2021 adamazakaria2021 commented Oct 5, 2025

Acceptance Criteria

  • Semantic HTML tags are used to structure the webpage.
  • The page scores 100 for Accessibility in the Lighthouse audit.
  • The page header includes a title and description.
  • The articles section has three unique articles, each including a title, summary, and a link.
  • The page footer is fixed to the bottom of the viewport.
  • The webpage is styled using a linked .css file.
  • The webpage is properly committed and pushed to a branch on GitHub.

@netlify
Copy link

netlify bot commented Oct 5, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit e36908c
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68e2e8f23bd4fc0008917de9
😎 Deploy Preview https://deploy-preview-896--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 88 (🔴 down 12 from production)
SEO: 82 (🔴 down 4 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@adamazakaria2021 adamazakaria2021 added Module-Onboarding The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 5, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there are a few issues with your submission.

  1. For wireframes the content is not correct, please review the wireframe readme
  2. You seem to have committed the form controls part here, please move that to the relevant branch

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 6, 2025
@adamazakaria2021 adamazakaria2021 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 7, 2025
@illicitonion
Copy link
Member

Hi @adamazakaria2021 - you added a "Needs Review" label, but didn't push any changes since your last comments. Did you forget to push changes?

@illicitonion illicitonion removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants