Skip to content

Conversation

@adamazakaria2021
Copy link

@adamazakaria2021 adamazakaria2021 commented Oct 4, 2025

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

@netlify
Copy link

netlify bot commented Oct 4, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 56d8c5c
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68e821a9bbe5bf000722b72f
😎 Deploy Preview https://deploy-preview-891--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 95 (🟢 up 9 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@adamazakaria2021 adamazakaria2021 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Oct 4, 2025
@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@adamazakaria2021 adamazakaria2021 added the Module-Onboarding The name of the module. label Oct 4, 2025
@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@adamazakaria2021 adamazakaria2021 added 📅 Sprint 2 Assigned during Sprint 2 of this module and removed 📅 Sprint 1 Assigned during Sprint 1 of this module labels Oct 4, 2025
@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@adamazakaria2021 adamazakaria2021 changed the title Manchester | September-25 | Mohamed Zakaria | Sprint1 | Form control Manchester | September-25 | Mohamed Zakaria | Sprint 2 | Form control Oct 4, 2025
@adamazakaria2021 adamazakaria2021 changed the title Manchester | September-25 | Mohamed Zakaria | Sprint 2 | Form control Manchester | ITP-September-2025 | Mohamed Zakaria | Sprint 2 | Form control Oct 4, 2025
@adamazakaria2021 adamazakaria2021 changed the title Manchester | ITP-September-2025 | Mohamed Zakaria | Sprint 2 | Form control Manchester | ITP-September-2025 | Mohamed Zakaria | Sprint 2 | Form-Controls Oct 4, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no committed files here - can you make sure you've done the task and pushed it?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 6, 2025
@adamazakaria2021 adamazakaria2021 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 7, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's tasks, I have spotted a few areas where you could improve code further

Some of the inputs are not being required for submission, can you fix that?

Can you see in the readme where it defines a valid name? Can you implement that check?

Did you mean to make changes to the wireframe file? We try to keep pull requests specific to just the files in the feature we are changing - for this, everything within the sprint task directory.

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants