Skip to content

Conversation

@sofayas
Copy link

@sofayas sofayas commented Oct 3, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Implemented webpage based on the provided wireframe design.

Added semantic HTML structure (header, main, three articles, footer).

Each article contains a title, short description, and external resource link.

Applied grid-based layout and styling via style.css.

Ensured footer is fixed at the bottom of the page.

Updated content to explain README files, wireframes, and Git branches.

Validated HTML with W3C and checked accessibility with Lighthouse.

Briefly explain your PR.
This PR implements the Wireframe project from the onboarding module.

Created a semantic HTML page with header, three articles, and footer.

Each article explains:

What a README file is

What a wireframe is

What a Git branch is

Linked an external CSS file (style.css) for layout and design.

Footer is fixed to the bottom of the viewport.

Code was validated and tested with Lighthouse for accessibility.

Questions

Ask any questions you have for your reviewer.

@netlify
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit c774ecf
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68e0193a9630de000856ee48
😎 Deploy Preview https://deploy-preview-886--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@sofayas sofayas added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 3, 2025
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 6, 2025
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@sofayas
Copy link
Author

sofayas commented Oct 6, 2025

This looks good to me

thanks

@illicitonion illicitonion changed the title Manchester | ITP-Sep-2025 | Sofayas Solomon | Sprint 1 | Wirfram Manchester | ITP-Sep-2025 | Sofayas Solomon | Sprint 1 | Wireframe Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants