Skip to content

Conversation

Shayida999
Copy link

✅ Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

📝 Changelist

  • Completed the Wireframe task from the Form Controls module
  • Added index.html, style.css, and assets like images and placeholder SVG
  • Designed layout with 3 articles, responsive for mobile and desktop

Questions

  • None for now

Copy link

netlify bot commented Sep 6, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 2738289
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68bc117a6391cb000829c78f
😎 Deploy Preview https://deploy-preview-748--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Sep 6, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@Shayida999 Shayida999 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 6, 2025
Copy link

github-actions bot commented Sep 6, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@Shayida999 Shayida999 changed the title Sheffield | September | Xiayidan Abudu | Wireframe Sheffield | September | Xiayidan Abudu | Sprint 2 | Wireframe Sep 6, 2025
Copy link

github-actions bot commented Sep 6, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Shayida999 Shayida999 changed the title Sheffield | September | Xiayidan Abudu | Sprint 2 | Wireframe Sheffield | September | Xiayidan Abudu | Wireframe Sep 6, 2025
Copy link

github-actions bot commented Sep 6, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@Shayida999 Shayida999 changed the title Sheffield | September | Xiayidan Abudu | Wireframe Sheffield | September | Xiayidan Abudu | Sprint 1 | Wireframe Sep 6, 2025
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 8, 2025
@jenny-alexander jenny-alexander self-requested a review September 8, 2025 22:36
@jenny-alexander
Copy link

Your wireframe looks really good - great job!

Here are a few changes I'd like you to implement to improve your application:

  1. The right arrow on the buttons is misleading. This icon is normally used to indicate "play". Can you remove it or use a different one?
Screenshot 2025-09-10 at 10 29 46 PM
  1. The title in your first article has a smaller font than the other articles. According to the wireframe design in the instructions, the article titles should have the same size font.
Screenshot 2025-09-10 at 7 12 30 AM
  1. Formatting your code (within the IDE) helps it to be aligned and easier to maintain. If you right-click in VS Code, you should see the option to 'Format Document' option. Try this and you should see your html file formatted nicely. :)

<p>
This is the default, provided code and no changes have been made yet.
</p>
<p>&copy; 2025 CodeYourFuture — All rights reserved.</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion -> Adding your name in the footer is a great way to market yourself to employers (once you are building your portfolio and looking for work!).
If you're not comfortable putting your name, that's ok 😃

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review with trainee action still to take.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants