Skip to content

WestMidlands | 26-ITP-Jan | Seid Hagos| Sprint 2 | Feature/form control#1134

Draft
seiddhagoss wants to merge 3 commits intoCodeYourFuture:mainfrom
seiddhagoss:main
Draft

WestMidlands | 26-ITP-Jan | Seid Hagos| Sprint 2 | Feature/form control#1134
seiddhagoss wants to merge 3 commits intoCodeYourFuture:mainfrom
seiddhagoss:main

Conversation

@seiddhagoss
Copy link

@seiddhagoss seiddhagoss commented Feb 4, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer. You must remove this section if you have no questions.

Refactor CSS variables and layout styles for better organization and maintainability.
Updated the content and structure of the index.html file to provide a more comprehensive overview of README files, wireframes, and Git branches.
@netlify
Copy link

netlify bot commented Feb 4, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 47f3580
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6983a9b5aafc7700083a1eb9
😎 Deploy Preview https://deploy-preview-1134--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 98 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

4 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@seiddhagoss seiddhagoss marked this pull request as draft February 5, 2026 10:39
@seiddhagoss seiddhagoss added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. NotCoursework labels Feb 5, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 6, 2026

You need to update the placeholder text in both the "Changelist" and the "Questions" sections in the PR description or else the validation bot will keep complaining and remove the "Needs Review" label.
image

Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any implementation of the Form-Controls exercise in this PR. I only see changes made to some files that are not related to the Form-Controls exercise.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. NotCoursework labels Feb 6, 2026
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

2 similar comments
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants