London | 26-ITP-Jan | Ebrahim Moqbel | Sprint 2 | Form Controls#1119
Open
Ebrahim-Moqbel wants to merge 9 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Ebrahim Moqbel | Sprint 2 | Form Controls#1119Ebrahim-Moqbel wants to merge 9 commits intoCodeYourFuture:mainfrom
Ebrahim-Moqbel wants to merge 9 commits intoCodeYourFuture:mainfrom
Conversation
Ebrahim-Moqbel
added
📅 Sprint 2
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Ebrahim-Moqbel
changed the title
This comment has been minimized.
This comment has been minimized.
Ebrahim-Moqbel
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Ebrahim-Moqbel
added
Needs Review
jenny-alexander
added
Review in progress
Contributor
jenny-alexander
left a comment
jenny-alexander
left a comment
There was a problem hiding this comment.
Hi @Ebrahim-Moqbel - nice effort with the form controls exercise 👏. Along with some comments in the code, here are additional suggestions that will strengthen your code.
- When naming HTML attributes, it's best practice to use 'kebab-case'. Therefore, for
name="T-shirtColor", it would bename="t-shirt-color".
Can you look through your html file and make those adjustments?
👀 https://developer.mozilla.org/en-US/docs/Glossary/Kebab_case - I think the code comments can be removed since their intention was to help you complete the exercise. Comments in the code can be useful for:
- Describing complex logic or workarounds
- Explaining "why," not "what"
- TODO notes for incomplete work
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| <h2>By Ebraim Moqbel</h2> |
Contributor
There was a problem hiding this comment.
<h2> announces a major section in the footer. Since your name is the only thing in the footer, a different tag should be used. Can you think of a more appropriate tag?
| <!-- provide three options for the T-shirts color, | ||
| make sure that they don't pick other colors--> | ||
| <fieldset> | ||
| <legend required>T-shirt Color</legend> |
Contributor
There was a problem hiding this comment.
For the T-shirt color radio buttons:
- I'm able to submit the form without choosing a colour. The colour is required.
- Does the
<legend>tag supportrequired? Try researching online or asking AI to tell you what attributes are allowed for<legend>. - Currently, the name is placed before the radio button input. For better UX, try placing the radio button before the label.
| <!-- provide 6 options XS, S, M, L, XL, XXL | ||
| for the customer to chose the color --> | ||
| <div> | ||
| <label for="T-shirtSize"></label> |
Contributor
There was a problem hiding this comment.
The label doesn't have text that is rendered on the UI.
jenny-alexander
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have made a form controls and made all the field required and for the color I made radio labels and named them the same to be at least one selected required.
Questions