Skip to content

WestMidlands | 26-ITP-Jan | Tasleem Adedokun | Sprint 2 | Feature/form control#1101

Open
tasleemadedokun wants to merge 11 commits intoCodeYourFuture:mainfrom
tasleemadedokun:feature/form-control
Open

WestMidlands | 26-ITP-Jan | Tasleem Adedokun | Sprint 2 | Feature/form control#1101
tasleemadedokun wants to merge 11 commits intoCodeYourFuture:mainfrom
tasleemadedokun:feature/form-control

Conversation

@tasleemadedokun
Copy link

@tasleemadedokun tasleemadedokun commented Jan 31, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have prepared a form page using the README instructions and I have also made some commit and added css to make the accessibility 100%

@netlify
Copy link

netlify bot commented Jan 31, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 0359f59
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6984d093d979c7000715a554
😎 Deploy Preview https://deploy-preview-1101--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@tasleemadedokun tasleemadedokun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@tasleemadedokun tasleemadedokun changed the title WestMidlands | 26-ITP-Jan | Tasleem Adedokun| Sprint 1| Feature/form control WestMidlands | 26-ITP-Jan | Tasleem Adedokun| Sprint 2| Feature/form control Jan 31, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@tasleemadedokun tasleemadedokun changed the title WestMidlands | 26-ITP-Jan | Tasleem Adedokun| Sprint 2| Feature/form control WestMidlands | 26-ITP-Jan | Tasleem Adedokun| Sprint 2 | Feature/form control Jan 31, 2026
@github-actions

This comment has been minimized.

@tasleemadedokun tasleemadedokun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@tasleemadedokun tasleemadedokun changed the title WestMidlands | 26-ITP-Jan | Tasleem Adedokun| Sprint 2 | Feature/form control WestMidlands | 26-ITP-Jan | Tasleem Adedokun| Sprint 2| Feature/form control Jan 31, 2026
@github-actions

This comment has been minimized.

@tasleemadedokun tasleemadedokun changed the title WestMidlands | 26-ITP-Jan | Tasleem Adedokun| Sprint 2| Feature/form control WestMidlands | 26-ITP-Jan | Tasleem Adedokun| Sprint2| Feature/form control Jan 31, 2026
@github-actions

This comment has been minimized.

@tasleemadedokun tasleemadedokun changed the title WestMidlands | 26-ITP-Jan | Tasleem Adedokun| Sprint2| Feature/form control WestMidlands | 26-ITP-Jan | Tasleem Adedokun| Sprint 2 | Feature/form control Jan 31, 2026
@github-actions

This comment has been minimized.

@tasleemadedokun tasleemadedokun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 31, 2026
@tasleemadedokun tasleemadedokun changed the title WestMidlands | 26-ITP-Jan | Tasleem Adedokun| Sprint 2 | Feature/form control WestMidlands | 26-ITP-Jan | Tasleem Adedokun | Sprint 2 | Feature/form control Jan 31, 2026
@github-actions

This comment has been minimized.

@tasleemadedokun tasleemadedokun added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Onboarding The name of the module. labels Jan 31, 2026
@jenny-alexander jenny-alexander self-requested a review February 5, 2026 13:04
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 5, 2026
Copy link
Contributor

@jenny-alexander jenny-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tasleemadedokun - thanks for submitting this PR. Your form has some of the basic requirements done.

There are a few requirements missing:

<fieldset>

<legend>CHOICE</legend>
<ul>
Copy link
Contributor

@jenny-alexander jenny-alexander Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The radio buttons are styled a bit differently . What if you were to remove the list elements? Will it look more aligned?

Image

<label for="size"> Size</label>
<select id="size" name="size" required>
<option value=""> SELECT </option>
<option value="xtra small">XS</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For your <option> values, it's a good idea to avoid using spaces. It's technically okay in HTML but if your form data was sent to a backend system, spaces might causes headaches for systems processing the data.
So, my suggestion is to use 'kebab-case' for multi-word values (i.e. xtra small could be xtra-small).

<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
<h2>TASLEEM ADEDOKUN</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using <h2> tag here implies that there is a new section starting. Since a footer name is considered minimal information, it doesn't need a heading. 🙂 Can you think of a better tag to use for your name?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using <h2> tag here implies that there is a new section starting. Since a footer name is considered minimal information, it doesn't need a heading. 🙂 Can you think of a better tag to use for your name?

Hi @jenny-alexander ,
Thank you very much for taking the time to review my work. To be sincere, I had zero knowledge of coding until I joined CYF. I am trying my best, and I am glad you spaced the correction.

However, I have a question? Before I added the CSS, my Lighthouse score was not 100%. Can I get 100% without CSS?
Thanks once again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're doing a great job 😀

Absolutely you can get a 100% accessibility score on Lighthouse without using CSS. What accessibility issues were you getting? Did you try to ask AI (ChatGPT, Gemini, Claude, etc) about the accessibility issue?
I can also help if you aren't able to figure it out.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jenny-alexander , thank you very much i have done all neccesary changes.

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 5, 2026
@tasleemadedokun
Copy link
Author

tasleemadedokun commented Feb 5, 2026 via email

@tasleemadedokun tasleemadedokun added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants