London | JAN-26 | Divine Mankrado | Sprint 2 | Form Control#1091
Open
divinmank wants to merge 34 commits intoCodeYourFuture:mainfrom
Open
London | JAN-26 | Divine Mankrado | Sprint 2 | Form Control#1091divinmank wants to merge 34 commits intoCodeYourFuture:mainfrom
divinmank wants to merge 34 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
divinmank
changed the title
This comment has been minimized.
This comment has been minimized.
divinmank
changed the title
This comment has been minimized.
This comment has been minimized.
divinmank
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
divinmank
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
divinmank
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
divinmank
added
the
Needs Review
3 tasks
MorganDavid
reviewed
Jan 31, 2026
Comment on lines
2
to
20
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <meta http-equiv="X-UA-Compatible" content="ie-edge"> | ||
| <title>Results</title> | ||
| </head> | ||
| <body> | ||
| <div id="results"></div> | ||
| <a href="/">Back to Form</a> | ||
| <script> | ||
| const resultsList = document.getElementById('results') | ||
| new URLSearchParams(window.location.search).forEach((value,name) => { | ||
| resultsList.append(`${name}: ${value}`) | ||
| resultsList.append(document.createElement('br')) | ||
| }) | ||
| </script> | ||
| </body> | ||
| </html> No newline at end of file |
There was a problem hiding this comment.
I'm not sure what this file does? One of the requirements is not to use javascript.
This page seems to be unrelated to the task?
Author
There was a problem hiding this comment.
I was following the video attached in the prep. Since the video followed closely, and they said that this was boilerplate code, I thought that the JavaScript was required for the page to function.
MorganDavid
added
Complete
divinmank
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
My code asks the user their name and email which has to be text only. Then it gives them one choice between the options red, green and blue to select their T-shirt color. It then gives a dropdown selection for what size to pick.
Questions
I have none at this moment.