London | 26-ITP-January | Divine Mankrado | Sprint 1 | Wireframe#1076
Open
divinmank wants to merge 13 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-January | Divine Mankrado | Sprint 1 | Wireframe#1076divinmank wants to merge 13 commits intoCodeYourFuture:mainfrom
divinmank wants to merge 13 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
divinmank
added
the
Needs Review
cjyuan
reviewed
Feb 3, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you:
- Center the "PAGE TITLE" and the "SHORT DESCRIPTION" beneath it
- Center the footer content
?
-
When there are a lot of text in the articles, or when the page is zoomed in to 200+%, the footer and the articles could overlap, making the footer content almost "unreadable". Can you address this issue?
Everything else look good.
cjyuan
added
Reviewed
divinmank
added
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
divinmank
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have designed my own wireframe.