Skip to content

Birmingham | 26-ITP-Jan | Ayodeji Ayorinde | Sprint 1 | Form Controls#1044

Open
Ayogit1 wants to merge 2 commits intoCodeYourFuture:mainfrom
Ayogit1:Form-Control---Task1
Open

Birmingham | 26-ITP-Jan | Ayodeji Ayorinde | Sprint 1 | Form Controls#1044
Ayogit1 wants to merge 2 commits intoCodeYourFuture:mainfrom
Ayogit1:Form-Control---Task1

Conversation

@Ayogit1
Copy link

@Ayogit1 Ayogit1 commented Jan 24, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@github-actions
Copy link

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@netlify
Copy link

netlify bot commented Jan 24, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit d1f86e5
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/697a5871b29e5900094988cf
😎 Deploy Preview https://deploy-preview-1044--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@github-actions
Copy link

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

3 similar comments
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Ayogit1
Copy link
Author

Ayogit1 commented Feb 2, 2026

This PR needs review.
Link: #1044

Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Form-Controls is in Sprint-2 (not Sprint-1).You need to update your PR title to pass the automated check.

  • In your PR description, you will need to replace the placeholder text (but keep the headers) to pass the automated check.

image
  • The form is missing a Submit button.


<p>
<label for="name">What is your name?*</label>
<input type="text" id="name" name="user_name" required>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?

Comment on lines +32 to +33
<input type="radio" required name="colour" id="r1" value="Green">
<label for="r1">Green</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For best practice, we should use meaningful names for id and class.

In this case, we can avoid using the id and for attributes
if we wrapped the input element inside the label tags:

      <label>
        <input type="radio" required name="colour" value="Green">
        Green
      </label>

@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Ayogit1
Copy link
Author

Ayogit1 commented Feb 5, 2026

This task is completed.

@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 5, 2026
@Ayogit1
Copy link
Author

Ayogit1 commented Feb 5, 2026

Couldn't figure out how to rename the PR on CodeYourFuture repository.

Recreated the PR for Form Controls:

Ayogit1#8

Birmingham | 26-ITP-Jan | Ayodeji Ayorinde | Sprint 2 | Form Controls

@cjyuan
Copy link
Contributor

cjyuan commented Feb 5, 2026

Note: The new PR you created is on your repo, not on CYF's repo. The PR to be submitted in ITP needs to be created on CYF's repo. Anyway, you don't need to create a new PR.

On the PR page,

  • To edit the title, click the "Edit" button next to the title.
  • To edit the PR description, click the "..." icon and select "Edit".
image

Please note that if you had made and committed changes in the cloned repo on your computer, you will need to sync/push the commits to GitHub for them to appear on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants