Glasgow | Prati Amalden | Module Legacy Code | Hashtag link doesn't work correctly #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PratiAmalden
added
the
Needs Review
mjpeet
reviewed
Oct 26, 2025
mjpeet
left a comment
mjpeet
left a comment
There was a problem hiding this comment.
the code changes in the bug/hashtag-link-not-working branch successfully fix the issue. great work!
| if (!text) return text; | ||
| return text.replace( | ||
| /\B#[^#]+/g, | ||
| /#\w+/g, |
There was a problem hiding this comment.
the change correctly matches only the hashtag word itself, stopping at any non-word character like spaces or punctuation. well done!
There was a problem hiding this comment.
grat addition of this test case in front-end/tests/formatHashtag.spec.mjs that verifies the problematic case is now handled correctly!
mjpeet
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.