-
-
Notifications
You must be signed in to change notification settings - Fork 68
London |26-JUL - SDC | Ping Wang |Sprint 3| middleware exercises CYF -1165 #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pathywang
wants to merge
2
commits into
CodeYourFuture:main
Choose a base branch
from
pathywang:Sprint-3-middlewares
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| </> gitignore | ||
| node_modules/ | ||
|
|
76 changes: 76 additions & 0 deletions
76
Sprint 3- middlewares/custom-written middlewares/custom.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| const express = require("express"); | ||
|
|
||
| const app = express(); | ||
| const PORT = 3000; | ||
|
|
||
| // Middleware 1: get username from X-Username header | ||
| function usernameMiddleware(req, res, next) { | ||
| const username = req.get("X-Username"); | ||
|
|
||
| if (username) { | ||
| req.username = username; | ||
| } else { | ||
| req.username = null; | ||
| } | ||
|
|
||
| next(); | ||
| } | ||
|
|
||
| // Middleware 2: parse and validate JSON array | ||
| function bodyMiddleware(req, res, next) { | ||
| let body = ""; | ||
|
|
||
| req.on("data", (chunk) => { | ||
| body += chunk; | ||
| }); | ||
|
|
||
| req.on("end", () => { | ||
| try { | ||
| const parsedBody = JSON.parse(body); | ||
|
|
||
| // Must be an array | ||
| if (!Array.isArray(parsedBody)) { | ||
| return res.status(400).send("Request body must be a JSON array."); | ||
| } | ||
|
|
||
| // Every item must be a string | ||
| if (!parsedBody.every((item) => typeof item === "string")) { | ||
| return res.status(400).send("Array must contain only strings."); | ||
| } | ||
|
|
||
| req.body = parsedBody; | ||
| next(); | ||
| } catch (error) { | ||
| res.status(400).send("Request body must be valid JSON."); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| // Use our two middlewares | ||
| app.use(usernameMiddleware); | ||
| app.use(bodyMiddleware); | ||
|
|
||
| // POST endpoint | ||
| app.post("/", (req, res) => { | ||
| const subjects = req.body; | ||
|
|
||
| if (req.username) { | ||
| res.send( | ||
| `You are authenticated as ${req.username}.\n\n` + | ||
| `You have requested information about ${subjects.length} ` + | ||
| `${subjects.length === 1 ? "subject" : "subjects"}` + | ||
| `${subjects.length > 0 ? ": " + subjects.join(", ") : ""}.` | ||
| ); | ||
| } else { | ||
| res.send( | ||
| `You are not authenticated.\n\n` + | ||
| `You have requested information about ${subjects.length} ` + | ||
| `${subjects.length === 1 ? "subject" : "subjects"}` + | ||
| `${subjects.length > 0 ? ": " + subjects.join(", ") : ""}.` | ||
| ); | ||
| } | ||
| }); | ||
|
|
||
| app.listen(PORT, () => { | ||
| console.log(`Server running on http://localhost:${PORT}`); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| const express = require("express"); | ||
|
|
||
| const app = express(); | ||
| const PORT = 3000; | ||
|
|
||
| // Built-in Express JSON middleware | ||
| app.use(express.json()); | ||
|
|
||
| // Custom username middleware | ||
| function usernameMiddleware(req, res, next) { | ||
| const username = req.get("X-Username"); | ||
|
|
||
| if (username) { | ||
| req.username = username; | ||
| } else { | ||
| req.username = null; | ||
| } | ||
|
|
||
| next(); | ||
| } | ||
|
|
||
| app.use(usernameMiddleware); | ||
|
|
||
| // POST endpoint | ||
| app.post("/", (req, res) => { | ||
| const subjects = req.body; | ||
|
|
||
| if (!Array.isArray(subjects) || | ||
| !subjects.every((subject) => typeof subject === "string")) { | ||
| return res.status(400).send("Invalid request body."); | ||
| } | ||
|
|
||
| if (req.username) { | ||
| res.send( | ||
| `You are authenticated as ${req.username}.\n\n` + | ||
| `You have requested information about ${subjects.length} ` + | ||
| `${subjects.length === 1 ? "subject" : "subjects"}` + | ||
| `${subjects.length > 0 ? ": " + subjects.join(", ") : ""}.` | ||
| ); | ||
| } else { | ||
| res.send( | ||
| `You are not authenticated.\n\n` + | ||
| `You have requested information about ${subjects.length} ` + | ||
| `${subjects.length === 1 ? "subject" : "subjects"}` + | ||
| `${subjects.length > 0 ? ": " + subjects.join(", ") : ""}.` | ||
| ); | ||
| } | ||
| }); | ||
|
|
||
| app.listen(PORT, () => { | ||
| console.log(`Server running on http://localhost:${PORT}`); | ||
| }); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an error but I would like to suggest a better approach.
What is the output difference between if and else statements. Read those articles.
Hope you find a "clean code" way!