Skip to content

Glasgow | 26-Jul-SDC | Shreef Ibrahim | Sprint 2 | chatApp - #110

Open
shreefAhmedM wants to merge 5 commits into
CodeYourFuture:mainfrom
shreefAhmedM:chatApp
Open

Glasgow | 26-Jul-SDC | Shreef Ibrahim | Sprint 2 | chatApp#110
shreefAhmedM wants to merge 5 commits into
CodeYourFuture:mainfrom
shreefAhmedM:chatApp

Conversation

@shreefAhmedM

@shreefAhmedM shreefAhmedM commented Aug 28, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1162

Changelist

A real time chat application with a Node.js/Express and WebSocket backend and a frontend chat interface. Added message history, real-time messaging, likes/dislikes, scheduled messages,... Also added Docker support for deployment.

Deployed frontend:

Deployed backend:

@github-actions

This comment has been minimized.

@shreefAhmedM shreefAhmedM added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 28, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Sep 1, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, this app is well written and has lots of functionality. I do have some questions about your implementation for you to answer, however.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed it was possible for me to run the app before I started the backend - why is that possible?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's true because the frontend is a separate application from the backend, so when you open the frontend, it will run and try to connect to the backend and if the connection fails it will display an appropriate message to the user. So the app can open and display the UI, but the actual chat functionality will not work properly without the backend.

}

// Update message
function updateMessage(message) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried testing liking an old message when there are newer ones below it? Does this approach to handling updated work correctly?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I see the issue when I click the like button updateMessage() function removes the old message by using "existing.remove()". And then add the message "addMessage(message);" instead of just finding the existing message and updating only its like/dislike buttons

I have updated, thank.

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 1, 2026
@shreefAhmedM shreefAhmedM added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@LonMcGregor

Copy link
Copy Markdown
Contributor

Great, the chat app seems to be working well now. Good work

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants