Glasgow | 26-Jul-SDC | Shreef Ibrahim | Sprint 2 | chatApp - #110
Glasgow | 26-Jul-SDC | Shreef Ibrahim | Sprint 2 | chatApp#110shreefAhmedM wants to merge 5 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, this app is well written and has lots of functionality. I do have some questions about your implementation for you to answer, however.
There was a problem hiding this comment.
I noticed it was possible for me to run the app before I started the backend - why is that possible?
There was a problem hiding this comment.
Yes, that's true because the frontend is a separate application from the backend, so when you open the frontend, it will run and try to connect to the backend and if the connection fails it will display an appropriate message to the user. So the app can open and display the UI, but the actual chat functionality will not work properly without the backend.
| } | ||
|
|
||
| // Update message | ||
| function updateMessage(message) { |
There was a problem hiding this comment.
Have you tried testing liking an old message when there are newer ones below it? Does this approach to handling updated work correctly?
There was a problem hiding this comment.
Yes, I see the issue when I click the like button updateMessage() function removes the old message by using "existing.remove()". And then add the message "addMessage(message);" instead of just finding the existing message and updating only its like/dislike buttons
I have updated, thank.
|
Great, the chat app seems to be working well now. Good work |
Self checklist
Task code
CYF-1162
Changelist
A real time chat application with a Node.js/Express and WebSocket backend and a frontend chat interface. Added message history, real-time messaging, likes/dislikes, scheduled messages,... Also added Docker support for deployment.
Deployed frontend:
Deployed backend: