Skip to content

Conversation

@MansoorM11
Copy link

Self checklist

  • [y ] I have committed my files one by one, on purpose, and for a reason
  • [ y] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [y ] I have tested my changes
  • [ y] My changes follow the style guide
  • [ y] My changes meet the requirements of this task

Changelist

Briefly explain your PR.
created multiple functions in order for the alarm clock to work correctly according to set requirements

Questions

Ask any questions you have for your reviewer.

@MansoorM11 MansoorM11 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 14, 2025
@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Wrong number of parts separated by |s

1 similar comment
@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Wrong number of parts separated by |s

@MansoorM11 MansoorM11 changed the title Glasgow | May-2025 | Mansoor Munawar | Data Groups| Sprint 3 | alarm clock Glasgow | May-2025 | Mansoor Munawar | Data Groups| Sprint 3 - alarm clock Aug 14, 2025
@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

@MansoorM11 MansoorM11 changed the title Glasgow | May-2025 | Mansoor Munawar | Data Groups| Sprint 3 - alarm clock Glasgow | May-2025 | Mansoor Munawar | Sprint 3 | alarm clock Aug 14, 2025
@arun-john
Copy link

Hi Mansoor, did you intend to submit this PR for the alarm clock assignment? That is indeed the right way, but looking at the files included, I can see files from other sprints and assignments too. Pls. correct.

@MansoorM11
Copy link
Author

Hi Arun , it was only meant to be alarm clock I may have created a branch from another branch rather than the main branch. If that is a problem I can do it again . Thanks

@arun-john
Copy link

Thanks, if you can correct and resubmit that would be great so we have a clean PR with only the relevant changes

@MansoorM11 MansoorM11 closed this Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants