Skip to content

West Midlands | ITP-MAY25 | Saleh Yousef | Module-Data-Groups | Sprint-2 #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

West Midlands | ITP-MAY25 | Saleh Yousef | Module-Data-Groups | Sprint-2 #622

wants to merge 8 commits into from

Conversation

SalehOmar-Y
Copy link

@SalehOmar-Y SalehOmar-Y commented Jul 16, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.
This PR implements and tests functions: createLookup, parseQueryString, tally, and invert.
Includes bug fixes, edge case handling, and validation with unit tests.

Questions

Ask any questions you have for your reviewer.

@SalehOmar-Y SalehOmar-Y added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module labels Jul 16, 2025
fearcyf
fearcyf reviewed Jul 17, 2025
View reviewed changes
Sprint-2/debug/author.js Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

fearcyf
fearcyf reviewed Jul 17, 2025
View reviewed changes
Sprint-2/debug/address.js Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

fearcyf
fearcyf reviewed Jul 17, 2025
View reviewed changes
fearcyf
fearcyf reviewed Jul 17, 2025
View reviewed changes
Sprint-2/interpret/invert.js Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both tests pass - well done

fearcyf
fearcyf reviewed Jul 17, 2025
View reviewed changes
Sprint-2/implement/contains.test.js Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests passed

fearcyf
fearcyf reviewed Jul 17, 2025
View reviewed changes
Sprint-2/implement/lookup.test.js Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed

fearcyf
fearcyf reviewed Jul 17, 2025
View reviewed changes
Sprint-2/implement/querystring.test.js
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test passed

fearcyf
fearcyf reviewed Jul 17, 2025
View reviewed changes
fearcyf
fearcyf reviewed Jul 17, 2025
View reviewed changes
Sprint-2/implement/tally.test.js Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests passed

fearcyf
fearcyf reviewed Jul 17, 2025
View reviewed changes
@fearcyf fearcyf self-assigned this Jul 17, 2025
@fearcyf fearcyf added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 17, 2025
illicitonion
illicitonion reviewed Jul 17, 2025
View reviewed changes
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generally looking really good, just one thing to pick up :)

Sprint-2/implement/querystring.test.js
Comment on lines +13 to +26

test("parses querystring with multiple values", () => {
expect(parseQueryString("name=John&age=30")).toEqual({
"name": "John",
"age": "30",
});
});
test("parses querystring with multiple values with same key", () => {
expect(parseQueryString("name=John&name=Jane")).toEqual({
"name": "Jane", // Last value should overwrite previous ones
});
});

test("parses querystring without key", () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good edge cases!

@SalehOmar-Y SalehOmar-Y added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 18, 2025
@illicitonion illicitonion added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 18, 2025
illicitonion
illicitonion reviewed Jul 18, 2025
View reviewed changes
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great, good job!

@SalehOmar-Y SalehOmar-Y mentioned this pull request Aug 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion left review comments

+1 more reviewer

@fearcyf fearcyf fearcyf left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@fearcyf fearcyf

Labels
Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SalehOmar-Y @illicitonion @fearcyf