Skip to content

Glasgow | ITP May 25 | Mirabelle Morah | Module Data Groups | Sprint 3 | Quote Generator #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Glasgow | ITP May 25 | Mirabelle Morah | Module Data Groups | Sprint 3 | Quote Generator #606

wants to merge 1 commit into from

Conversation

mirabellemorah
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

I added a different kind of background and changed quote

Questions

Ask any questions you have for your reviewer.

@mirabellemorah mirabellemorah added the Needs Review Participant to add when requesting review label Jul 14, 2025
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 17, 2025
LonMcGregor
LonMcGregor reviewed Jul 17, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job implementing the quote generator. It looks good and works well. You can close this task and move to the next one

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and review comments have been addressed and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 17, 2025
@mirabellemorah
Copy link
Author

Good job implementing the quote generator. It looks good and works well. You can close this task and move to the next one

Thanks!

@mirabellemorah mirabellemorah mentioned this pull request Jul 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirabellemorah @LonMcGregor