Skip to content

Scotland | ITP-May-2025 | Nataliia Volkova | Module-Data-Groups/Sprint 3/Feature/quote generator #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Scotland | ITP-May-2025 | Nataliia Volkova | Module-Data-Groups/Sprint 3/Feature/quote generator #597

wants to merge 5 commits into from

Conversation

Nataliia74
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Nataliia74 Nataliia74 added the Needs Review Participant to add when requesting review label Jul 13, 2025
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 17, 2025
LonMcGregor
LonMcGregor reviewed Jul 17, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this sprint, your quotes app works well. There's just one very minor thing to change and then you can close this task.

Sprint-3/quote-generator/index.html Outdated
<p id="author"></p>
<button type="button" id="new-quote">New quote</button>
<h1>Quotes</h1>
<div class="card" , id="wildCard">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to put comments separating the properties of HTML elements. a space is fine

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Leon, thank you for reviewing my code.

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 17, 2025
@Nataliia74 Nataliia74 added the Needs Review Participant to add when requesting review label Jul 17, 2025
@LonMcGregor
Copy link

Great! You can close this PR now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review labels Jul 18, 2025
@Nataliia74 Nataliia74 mentioned this pull request Jul 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nataliia74 @LonMcGregor