LONDON | MAY-2025 | HAKAN MURAT KAVUT | MODULE DATA-GROUPS SPRINT-2 #568
Conversation
day-lee
added
Review in progress
| @@ -1,3 +1,8 @@ | |||
| function contains() {} | |||
| function contains(list, prop) { | |||
| if (typeof list !== "object" || list === null || Array.isArray(list)) | |||
There was a problem hiding this comment.
Does typeof list !== "object" check weather the variable list is not an object? like string or another type?
| // implementation here | ||
| function createLookup(countryCurrencyPairs) { | ||
| const queryParams = {}; | ||
| for (let i = 0; i < countryCurrencyPairs.length; i++) { |
There was a problem hiding this comment.
Good job! It works as intended. As a challenge, would you like to try to refactor the code using for...of loop? It's up to you.
| @@ -3,10 +3,11 @@ function parseQueryString(queryString) { | |||
| if (queryString.length === 0) { | |||
There was a problem hiding this comment.
Good job!
In the real world, URLs are usually encoded with percent encoding to represent special characters. In URL, & can be used as a separator (key=value&key=value...) or special character within a key or value. if we were to use & as a special character, we need to encode it.
Can you refactor the code so that parseQueryString("a%25b=c%26d") results in { "a%b": "c&d" }?
FYI, %25 is same as %, %26 is same as &
day-lee
added
Reviewed
| for (const char of input) { | ||
| queryParams[char]=0; | ||
| } | ||
| for (const char of input) { |
There was a problem hiding this comment.
I think this code can be combined with the upper for...of loop using or operator ||. Can you think of less repetitive way to implement it?
Learners, PR Template
Self checklist
Changelist
In this PR, I implemented function in Sprint 2 folder and test cases are written for these functions
Questions
Ask any questions you have for your reviewer.