Skip to content

West-Midlands | 26-ITP-May | Maryam Janjua | Sprint 3 | Programmer Humour - #574

Open
maryam-devio wants to merge 1 commit into
CodeYourFuture:mainfrom
maryam-devio:feature/xkcd
Open

West-Midlands | 26-ITP-May | Maryam Janjua | Sprint 3 | Programmer Humour#574
maryam-devio wants to merge 1 commit into
CodeYourFuture:mainfrom
maryam-devio:feature/xkcd

Conversation

@maryam-devio

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have created the required files and fetched and displayed the latest XKCD humour comic using the API.

@maryam-devio maryam-devio added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Aug 21, 2026
@hey-hammad hey-hammad added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 25, 2026

@hey-hammad hey-hammad left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work overall. One minor suggestion would be to display an error message in the UI when the API call fails, rather than only logging it to the console. Thanks

@hey-hammad hey-hammad added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Data-Flows The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants